mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-12-24 18:08:26 +03:00
Code Issues Projects Releases Packages Wiki Activity

Don't leak password length through mask (#293)

Browse source
This commit is contained in:
Mark Cohen 2018-03-06 06:37:46 -06:00 committed by Kyle Spearrin
parent deb1ead4ea
commit 7c8f6a1cc7
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/App/Models/Page/VaultViewCipherPageModel.cs
View file

@ -114,7 +114,7 @@ namespace Bit.App.Models.Page
} }
} }
public string MaskedLoginPassword => RevealLoginPassword ? public string MaskedLoginPassword => RevealLoginPassword ?
LoginPassword : LoginPassword == null ? null : new string('•', LoginPassword.Length); LoginPassword : LoginPassword == null ? null : new string('•', 8);
public ImageSource LoginShowHideImage => RevealLoginPassword ? public ImageSource LoginShowHideImage => RevealLoginPassword ?
ImageSource.FromFile("eye_slash.png") : ImageSource.FromFile("eye.png"); ImageSource.FromFile("eye_slash.png") : ImageSource.FromFile("eye.png");
@ -622,7 +622,7 @@ namespace Bit.App.Models.Page
{ {
if(_maskedValue == null && Value != null) if(_maskedValue == null && Value != null)
{ {
_maskedValue = new string('•', Value.Length); _maskedValue = new string('•', 8);
} }
return _maskedValue; return _maskedValue;