mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-03-28 08:39:22 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fixed perf issues with IEnumerable. Fixed rate link and row heights for settings.

Browse source
This commit is contained in:
Kyle Spearrin 2016-07-26 19:21:57 -04:00
parent 39b7420c52
commit 6371343dc5
4 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/App/Pages/Settings/SettingsPage.cs
View file

@ -184,12 +184,6 @@ namespace Bit.App.Pages
} }
}; };
if(Device.OS == TargetPlatform.iOS)
{
table.RowHeight = -1;
table.EstimatedRowHeight = 44;
}
var rateLabel = new Label var rateLabel = new Label
{ {
LineBreakMode = LineBreakMode.WordWrap, LineBreakMode = LineBreakMode.WordWrap,
@ -279,7 +273,7 @@ namespace Bit.App.Pages
if(Device.OS == TargetPlatform.iOS) if(Device.OS == TargetPlatform.iOS)
{ {
var appStoreId = "1137397744"; var appStoreId = "1137397744";
Device.OpenUri(new Uri($"tms-apps://itunes.apple.com/WebObjects/MZStore.woa/wa/viewContentsUserReviews?id={appStoreId}&onlyLatestVersion=true&pageNumber=0&sortOrdering=1&type=Purple+Software")); Device.OpenUri(new Uri($"itms-apps://itunes.apple.com/WebObjects/MZStore.woa/wa/viewContentsUserReviews?id={appStoreId}&onlyLatestVersion=true&pageNumber=0&sortOrdering=1&type=Purple+Software"));
} }
} }

3
src/App/Pages/Vault/VaultAddSitePage.cs
View file

@ -45,7 +45,8 @@ namespace Bit.App.Pages
var nameCell = new FormEntryCell(AppResources.Name, nextElement: uriCell.Entry); var nameCell = new FormEntryCell(AppResources.Name, nextElement: uriCell.Entry);
var folderOptions = new List<string> { AppResources.FolderNone }; var folderOptions = new List<string> { AppResources.FolderNone };
var folders = _folderService.GetAllAsync().GetAwaiter().GetResult().OrderBy(f => f.Name?.Decrypt()); var folders = _folderService.GetAllAsync().GetAwaiter().GetResult()
.OrderBy(f => f.Name?.Decrypt()).ToList();
foreach(var folder in folders) foreach(var folder in folders)
{ {
folderOptions.Add(folder.Name.Decrypt()); folderOptions.Add(folder.Name.Decrypt());

3
src/App/Pages/Vault/VaultEditSitePage.cs
View file

@ -65,7 +65,8 @@ namespace Bit.App.Pages
generateCell.Tapped += GenerateCell_Tapped; ; generateCell.Tapped += GenerateCell_Tapped; ;
var folderOptions = new List<string> { AppResources.FolderNone }; var folderOptions = new List<string> { AppResources.FolderNone };
var folders = _folderService.GetAllAsync().GetAwaiter().GetResult().OrderBy(f => f.Name?.Decrypt()); var folders = _folderService.GetAllAsync().GetAwaiter().GetResult()
.OrderBy(f => f.Name?.Decrypt()).ToList();
int selectedIndex = 0; int selectedIndex = 0;
int i = 0; int i = 0;
foreach(var folder in folders) foreach(var folder in folders)

6
src/iOS.Extension/SiteListViewController.cs
View file

@ -42,7 +42,9 @@ namespace Bit.iOS.Extension
var siteService = Resolver.Resolve<ISiteService>(); var siteService = Resolver.Resolve<ISiteService>();
var sites = await siteService.GetAllAsync(); var sites = await siteService.GetAllAsync();
var siteModels = sites.Select(s => new SiteViewModel(s)); var siteModels = sites.Select(s => new SiteViewModel(s));
filteredSiteModels = siteModels.Where(s => s.Domain != null && s.Domain.BaseDomain == Context.DomainName.BaseDomain); filteredSiteModels = siteModels
.Where(s => s.Domain != null && s.Domain.BaseDomain == Context.DomainName.BaseDomain)
.ToList();
} }
Debug.WriteLine("BW LOG, Filtered sites at " + sw.ElapsedMilliseconds + "ms."); Debug.WriteLine("BW LOG, Filtered sites at " + sw.ElapsedMilliseconds + "ms.");
@ -126,6 +128,7 @@ namespace Bit.iOS.Extension
{ {
Debug.WriteLine("BW Log, Make new cell for list."); Debug.WriteLine("BW Log, Make new cell for list.");
cell = new UITableViewCell(UITableViewCellStyle.Subtitle, CellIdentifier); cell = new UITableViewCell(UITableViewCellStyle.Subtitle, CellIdentifier);
cell.DetailTextLabel.TextColor = cell.DetailTextLabel.TintColor = new UIColor(red: 0.47f, green: 0.47f, blue: 0.47f, alpha: 1.0f);
} }
return cell; return cell;
} }
@ -140,7 +143,6 @@ namespace Bit.iOS.Extension
var item = _tableItems.ElementAt(indexPath.Row); var item = _tableItems.ElementAt(indexPath.Row);
cell.TextLabel.Text = item.Name; cell.TextLabel.Text = item.Name;
cell.DetailTextLabel.Text = item.Username; cell.DetailTextLabel.Text = item.Username;
cell.DetailTextLabel.TextColor = cell.DetailTextLabel.TintColor = new UIColor(red: 0.47f, green: 0.47f, blue: 0.47f, alpha: 1.0f);
} }
public override void RowSelected(UITableView tableView, NSIndexPath indexPath) public override void RowSelected(UITableView tableView, NSIndexPath indexPath)