PM-3349 PM-3350 Fixed issue where creating an account with weak/exposed password would get stuck after the Captcha (if a captcha is shown)

Changed App.xaml.cs NavigateImpl to be private
This commit is contained in:
Dinis Vieira 2023-11-21 22:39:44 +00:00
parent 06a0195a6d
commit 62254aef8d
No known key found for this signature in database
GPG key ID: 9389160FF6C295F3
2 changed files with 4 additions and 2 deletions

View file

@ -530,7 +530,7 @@ namespace Bit.App
NavigateImpl(navTarget, navParams); NavigateImpl(navTarget, navParams);
} }
public void NavigateImpl(NavigationTarget navTarget, INavigationParams navParams) private void NavigateImpl(NavigationTarget navTarget, INavigationParams navParams)
{ {
switch (navTarget) switch (navTarget)
{ {

View file

@ -165,7 +165,9 @@ namespace Bit.App.Pages
AppResources.AnErrorHasOccurred, AppResources.Ok); AppResources.AnErrorHasOccurred, AppResources.Ok);
return; return;
} }
if (await IsPasswordWeakOrExposed())
//We only test weak/exposed password when "showLoading" is true otherwise it would be called twice in scenarios this method is called again after a Captcha
if (showLoading && await IsPasswordWeakOrExposed())
{ {
return; return;
} }