From 6212ef8fa96d7a5f6cf0c9166af4e40e2e934e68 Mon Sep 17 00:00:00 2001 From: Andrew Haisting <142518658+ahaisting-livefront@users.noreply.github.com> Date: Wed, 30 Aug 2023 14:46:53 -0500 Subject: [PATCH] Downgrade navigation version due to saved state bug (#18) --- .../com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt | 4 ---- gradle/libs.versions.toml | 6 +++++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt index 106b15f5d..266e96822 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt @@ -1,7 +1,5 @@ package com.x8bit.bitwarden.ui.feature.rootnav -import androidx.compose.animation.EnterTransition -import androidx.compose.animation.ExitTransition import androidx.compose.runtime.Composable import androidx.compose.runtime.getValue import androidx.lifecycle.compose.collectAsStateWithLifecycle @@ -27,8 +25,6 @@ fun RootNavScreen( NavHost( navController = navController, startDestination = SplashRoute, - enterTransition = { EnterTransition.None }, - exitTransition = { ExitTransition.None }, ) { splashDestinations() loginDestinations() diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 4414f4544..38a364d71 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -14,7 +14,11 @@ androidxComposeBom = "2023.06.01" androidxCore = "1.10.1" androidxHiltNavigationCompose = "1.0.0" androidxLifecycle = "2.6.1" -androidxNavigation = "2.7.0" +# Currently holding navigation at this version because of this bug: +# https://issuetracker.google.com/issues/298059596 +# When updating, ensure that rememeberSaveable works correctly through process death in +# child navigation destinations (BIT-201). +androidxNavigation = "2.5.3" androidxRoom = "2.5.2" detekt = "1.23.1" firebaseBom = "32.2.2"