mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-11-21 08:55:48 +03:00
Code Issues Projects Releases Packages Wiki Activity

BIT-589 Prevent crash on Landing when navigating with empty input (#59)

Browse source
This commit is contained in:
Andrew Haisting 2023-09-21 11:47:28 -05:00 committed by Álison Fernandes
parent 3de916cc20
commit 35483408b2
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt
View file

@ -49,6 +49,10 @@ class LandingViewModel @Inject constructor(
}
private fun handleContinueButtonClicked() {
// TODO: add actual validation here: BIT-193
if (mutableStateFlow.value.emailInput.isBlank()) {
return
}
sendEvent(LandingEvent.NavigateToLogin(mutableStateFlow.value.emailInput))
}

11
app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt
View file

@ -34,15 +34,24 @@ class LandingViewModelTest : BaseViewModelTest() {
@Test
fun `ContinueButtonClick should emit NavigateToLogin`() = runTest {
val viewModel = LandingViewModel(SavedStateHandle())
viewModel.trySendAction(LandingAction.EmailInputChanged("input"))
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(LandingAction.ContinueButtonClick)
assertEquals(
LandingEvent.NavigateToLogin(""),
LandingEvent.NavigateToLogin("input"),
awaitItem(),
)
}
}
@Test
fun `ContinueButtonClick with empty input should do nothing`() = runTest {
val viewModel = LandingViewModel(SavedStateHandle())
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(LandingAction.ContinueButtonClick)
}
}
@Test
fun `CreateAccountClick should emit NavigateToCreateAccount`() = runTest {
val viewModel = LandingViewModel(SavedStateHandle())