mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-10-31 15:15:34 +03:00
Code Issues Projects Releases Packages Wiki Activity

TDL-13 Removed workaround of null reference on LabelRenderer given that Xamarin forms has been updated with the fix (#1889)

Browse source
This commit is contained in:
Federico Maccaroni 2022-04-25 16:09:47 -03:00 committed by GitHub
parent 99828c7ead
commit 2cab62fda5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/iOS.Core/Renderers/CustomLabelRenderer.cs
View file

@ -22,19 +22,8 @@ namespace Bit.iOS.Core.Renderers
} }
protected override void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e) protected override void OnElementPropertyChanged(object sender, PropertyChangedEventArgs e)
{
try
{ {
base.OnElementPropertyChanged(sender, e); base.OnElementPropertyChanged(sender, e);
}
catch (NullReferenceException)
{
// Do nothing...
// There is an issue on Xamarin Forms which throws a null reference
// https://appcenter.ms/users/kspearrin/apps/bitwarden/crashes/errors/534094859u/overview
// TODO: Maybe something like this https://github.com/matteobortolazzo/HtmlLabelPlugin/pull/113 can be implemented to avoid this
// on html labels.
}
if (e.PropertyName == Label.FontProperty.PropertyName || if (e.PropertyName == Label.FontProperty.PropertyName ||
e.PropertyName == Label.TextProperty.PropertyName || e.PropertyName == Label.TextProperty.PropertyName ||