Add option to retrieve feature flag synchronously (#3692)

app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManager.kt

@@ -20,11 +20,19 @@ interface FeatureFlagManager {
 
     /**
      * Get value for feature flag with [key] and returns it as generic type [T].
-     * If no value is found the the given [key] its default value will be returned.
+     * If no value is found the given [key] its default value will be returned.
      * Cached flags can be invalidated with [forceRefresh]
      */
     suspend fun <T : Any> getFeatureFlag(
         key: FlagKey<T>,
         forceRefresh: Boolean,
     ): T
+
+    /**
+     * Gets the value for feature flag with [key] and returns it as generic type [T].
+     * If no value is found the given [key] its [FlagKey.defaultValue] will be returned.
+     */
+    fun <T : Any> getFeatureFlag(
+        key: FlagKey<T>,
+    ): T
 }

app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerImpl.kt

@@ -32,6 +32,12 @@ class FeatureFlagManagerImpl(
         serverConfigRepository
             .getServerConfig(forceRefresh = forceRefresh)
             .getFlagValueOrDefault(key = key)
+
+    override fun <T : Any> getFeatureFlag(key: FlagKey<T>): T =
+        serverConfigRepository
+            .serverConfigStateFlow
+            .value
+            .getFlagValueOrDefault(key = key)
 }
 
 private fun <T : Any> ServerConfig?.getFlagValueOrDefault(key: FlagKey<T>): T {

app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FeatureFlagManagerTest.kt

@@ -216,6 +216,42 @@ class FeatureFlagManagerTest {
             flagValue,
         )
     }
+
+    @Test
+    fun `synchronous getFeatureFlag should return stored value when present`() {
+        fakeServerConfigRepository.serverConfigValue = SERVER_CONFIG.copy(
+            serverData = SERVER_CONFIG.serverData.copy(
+                featureStates = mapOf("dummy-int" to JsonPrimitive(true)),
+            ),
+        )
+
+        val flagValue = manager.getFeatureFlag(key = FlagKey.DummyInt)
+
+        assertEquals(Int.MIN_VALUE, flagValue)
+    }
+
+    @Test
+    fun `synchronous getFeatureFlag should return default value if flag is incorrect type`() {
+        val value = "nonDefaultValue"
+        fakeServerConfigRepository.serverConfigValue = SERVER_CONFIG.copy(
+            serverData = SERVER_CONFIG.serverData.copy(
+                featureStates = mapOf("dummy-string" to JsonPrimitive(value)),
+            ),
+        )
+
+        val flagValue = manager.getFeatureFlag(key = FlagKey.DummyString)
+
+        assertEquals(value, flagValue)
+    }
+
+    @Test
+    fun `synchronous getFeatureFlag should return default value if no flags available`() {
+        fakeServerConfigRepository.serverConfigValue = null
+
+        val flagValue = manager.getFeatureFlag(key = FlagKey.DummyString)
+
+        assertEquals("defaultValue", flagValue)
+    }
 }
 
 private val SERVER_CONFIG = ServerConfig(