mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-11-21 17:05:44 +03:00
Code Issues Projects Releases Packages Wiki Activity

PM-14201: Update the default divider thickness (#4182)

Browse source
This commit is contained in:
David Perez 2024-10-29 08:56:57 -05:00 committed by GitHub
parent f3916b4ef6
commit 150c8e0312
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt
View file

@ -1,7 +1,6 @@
package com.x8bit.bitwarden.ui.platform.base.util
import androidx.compose.foundation.layout.padding
import androidx.compose.material3.DividerDefaults
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.TopAppBarScrollBehavior
import androidx.compose.runtime.Composable
@ -71,7 +70,6 @@ fun Modifier.scrolledContainerBottomDivider(
this.bottomDivider(
alpha = topAppBarScrollBehavior.toScrolledContainerDividerAlpha(),
enabled = enabled,
thickness = (0.5).dp,
)
/**
@ -83,7 +81,7 @@ fun Modifier.scrolledContainerBottomDivider(
fun Modifier.bottomDivider(
paddingStart: Dp = 0.dp,
paddingEnd: Dp = 0.dp,
thickness: Dp = DividerDefaults.Thickness,
thickness: Dp = (0.5).dp,
color: Color = BitwardenTheme.colorScheme.stroke.divider,
enabled: Boolean = true,
alpha: Float = 1f,

1
app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenMediumTopAppBar.kt
View file

@ -73,7 +73,6 @@ fun BitwardenMediumTopAppBar(
TopAppBarDividerStyle.STATIC -> true
TopAppBarDividerStyle.ON_SCROLL -> false
},
thickness = (0.5).dp,
),
actions = actions,
)

3
app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt
View file

@ -17,7 +17,6 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.input.ImeAction
import androidx.compose.ui.unit.dp
import com.x8bit.bitwarden.R
import com.x8bit.bitwarden.ui.platform.base.util.bottomDivider
import com.x8bit.bitwarden.ui.platform.base.util.mirrorIfRtl
@ -49,7 +48,7 @@ fun BitwardenSearchTopAppBar(
TopAppBar(
modifier = modifier
.testTag(tag = "HeaderBarComponent")
.bottomDivider(thickness = (0.5).dp),
.bottomDivider(),
colors = bitwardenTopAppBarColors(),
scrollBehavior = scrollBehavior,
navigationIcon = {

1
app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenTopAppBar.kt
View file

@ -125,7 +125,6 @@ fun BitwardenTopAppBar(
TopAppBarDividerStyle.STATIC -> true
TopAppBarDividerStyle.ON_SCROLL -> false
},
thickness = (0.5).dp,
)
if (titleTextHasOverflow) {

2
app/src/main/java/com/x8bit/bitwarden/ui/platform/components/divider/BitwardenHorizontalDivider.kt
View file

@ -19,7 +19,7 @@ import com.x8bit.bitwarden.ui.platform.theme.BitwardenTheme
@Composable
fun BitwardenHorizontalDivider(
modifier: Modifier = Modifier,
thickness: Dp = 1.dp,
thickness: Dp = (0.5).dp,
color: Color = BitwardenTheme.colorScheme.stroke.divider,
) {
HorizontalDivider(