From 0c83a1099ff4be2a8b6c4c444295a04600c5da30 Mon Sep 17 00:00:00 2001 From: David Perez Date: Wed, 2 Oct 2024 12:57:34 -0500 Subject: [PATCH] PM-10628: Update pin dialog title (#4017) --- .../platform/components/toggle/BitwardenUnlockWithPinSwitch.kt | 2 +- app/src/main/res/values/strings.xml | 1 + .../ui/auth/feature/accountsetup/SetupUnlockScreenTest.kt | 2 +- .../settings/accountsecurity/AccountSecurityScreenTest.kt | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithPinSwitch.kt b/app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithPinSwitch.kt index a398a0c34..a4d5aac0f 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithPinSwitch.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithPinSwitch.kt @@ -84,7 +84,7 @@ fun BitwardenUnlockWithPinSwitch( shouldShowPinConfirmationDialog -> { BitwardenTwoButtonDialog( - title = stringResource(id = R.string.unlock_with_pin), + title = stringResource(id = R.string.require_master_password_on_app_restart), message = stringResource(id = R.string.pin_require_master_password_restart), confirmButtonText = stringResource(id = R.string.yes), dismissButtonText = stringResource(id = R.string.no), diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 0f999b8a5..86bf4f785 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -456,6 +456,7 @@ Scanning will happen automatically. Copy note Exit Are you sure you want to exit Bitwarden? + Require master password on app restart? Do you want to require unlocking with your master password when the application is restarted? Black Nord diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreenTest.kt b/app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreenTest.kt index 0b0eb67bc..c931a9c42 100644 --- a/app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreenTest.kt +++ b/app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreenTest.kt @@ -343,7 +343,7 @@ class SetupUnlockScreenTest : BaseComposeTest() { .performClick() composeTestRule - .onAllNodesWithText(text = "Unlock with PIN code") + .onAllNodesWithText(text = "Require master password on app restart?") .filterToOne(hasAnyAncestor(isDialog())) .assertIsDisplayed() composeTestRule diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt b/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt index 8bd2b410a..3f7a9e99b 100644 --- a/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt +++ b/app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt @@ -370,7 +370,7 @@ class AccountSecurityScreenTest : BaseComposeTest() { .performClick() composeTestRule - .onAllNodesWithText("Unlock with PIN code") + .onAllNodesWithText("Require master password on app restart?") .filterToOne(hasAnyAncestor(isDialog())) .assertIsDisplayed() composeTestRule