mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-12-25 18:38:27 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix truncated bottom on Password generator when large font size is set on Android (#1782)

Browse source
This commit is contained in:
Federico Maccaroni 2022-02-15 19:10:43 -03:00 committed by GitHub
parent 95581bd4d9
commit 02562be8c7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 241 additions and 237 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/App/Pages/Generator/GeneratorPage.xaml
View file

@ -36,6 +36,10 @@
</ResourceDictionary> </ResourceDictionary>
</ContentPage.Resources> </ContentPage.Resources>
<!--WORKAROUND: Wrapped in a ContentView to fix bottom screen but when using large font size on Android.
Check when https://github.com/xamarin/Xamarin.Forms/pull/15076 is released that may fix this without wrapping
in ContentView.-->
<ContentView>
<ScrollView Padding="0, 0, 0, 20"> <ScrollView Padding="0, 0, 0, 20">
<StackLayout Spacing="0" Padding="0"> <StackLayout Spacing="0" Padding="0">
<StackLayout StyleClass="box"> <StackLayout StyleClass="box">
@ -161,9 +165,9 @@
<Label <Label
Text="{Binding Length}" Text="{Binding Length}"
StyleClass="box-sub-label" StyleClass="box-sub-label"
WidthRequest="30"
VerticalOptions="CenterAndExpand" VerticalOptions="CenterAndExpand"
HorizontalTextAlignment="End" /> HorizontalTextAlignment="End"
WidthRequest="50" />
<controls:ExtendedSlider <controls:ExtendedSlider
DragCompleted="LengthSlider_DragCompleted" DragCompleted="LengthSlider_DragCompleted"
Value="{Binding Length}" Value="{Binding Length}"
@ -282,5 +286,5 @@
</StackLayout> </StackLayout>
</StackLayout> </StackLayout>
</ScrollView> </ScrollView>
</ContentView>
</pages:BaseContentPage> </pages:BaseContentPage>

2
src/App/Styles/Base.xaml
View file

@ -363,7 +363,7 @@
<Setter Property="Orientation" <Setter Property="Orientation"
Value="Horizontal" /> Value="Horizontal" />
<Setter Property="Spacing" <Setter Property="Spacing"
Value="10" /> Value="5" />
</Style> </Style>
<Style TargetType="Button" <Style TargetType="Button"
ApplyToDerivedTypes="True" ApplyToDerivedTypes="True"