From 6d873e76fc63544673bda673ff377c0b9b810706 Mon Sep 17 00:00:00 2001
From: Tadas Vosylius <33595979+tadasvosylius@users.noreply.github.com>
Date: Sun, 16 Oct 2022 20:08:36 +0300
Subject: [PATCH] fix: replace v-html with conditional rendering in torrent
 details view (#513)

---
 src/components/TorrentDetail/Tabs/Info.vue | 28 ++++++++++++++++--
 src/filters.js                             | 10 +------
 src/helpers.js                             | 34 ++++++++++++++++++++++
 tests/unit/filters.spec.js                 | 22 +-------------
 tests/unit/helpers.spec.js                 | 27 +++++++++++++++++
 5 files changed, 88 insertions(+), 33 deletions(-)
 create mode 100644 tests/unit/helpers.spec.js

diff --git a/src/components/TorrentDetail/Tabs/Info.vue b/src/components/TorrentDetail/Tabs/Info.vue
index e97b4264..a65da52b 100644
--- a/src/components/TorrentDetail/Tabs/Info.vue
+++ b/src/components/TorrentDetail/Tabs/Info.vue
@@ -139,19 +139,34 @@
           <td :class="commonStyle">
             {{ $t('modals.detail.pageInfo.trackers') }}
           </td>
-          <td> {{ torrent.tracker }} </td>
+          <td>
+            <span v-for="trackersPart in splitString(torrent.tracker)">
+              <a v-if="stringContainsUrl(trackersPart)" _target="blank" :href="trackersPart">{{ trackersPart }}</a>
+              <span v-else>{{ trackersPart }}</span>
+            </span>
+          </td>
         </tr>
         <tr v-if="createdBy">
           <td :class="commonStyle">
             {{ $t('modals.detail.pageInfo.createdBy') }}
           </td>
-          <td> {{ createdBy }} </td>
+          <td>
+            <span v-for="createdByPart in splitString(createdBy)">
+              <a v-if="stringContainsUrl(createdByPart)" _target="blank" :href="createdByPart">{{ createdByPart }}</a>
+              <span v-else>{{ createdByPart }}</span>
+            </span>
+          </td>
         </tr>
         <tr v-if="comment">
           <td :class="commonStyle">
             {{ $t('torrent.comments') | titleCase }}
           </td>
-          <td> {{ comment }} </td>
+          <td>
+            <span v-for="commentPart in splitString(comment)">
+              <a v-if="stringContainsUrl(commentPart)" _target="blank" :href="commentPart">{{ commentPart }}</a>
+              <span v-else>{{ commentPart }}</span>
+            </span>
+          </td>
         </tr>
 
         <tr>
@@ -232,6 +247,7 @@
 <script>
 import { FullScreenModal } from '@/mixins'
 import qbit from '@/services/qbit'
+import { splitByUrl, stringContainsUrl } from '@/helpers'
 
 export default {
   name: 'Info',
@@ -300,6 +316,12 @@ export default {
           ctx.fillRect((data.length - rectWidth), 0, rectWidth, canvas.height)
         }
       }
+    },
+    stringContainsUrl(string) {
+      return stringContainsUrl(string)
+    },
+    splitString(string) {
+      return splitByUrl(string)
     }
   }
 }
diff --git a/src/filters.js b/src/filters.js
index cda1e07b..fcbe3541 100644
--- a/src/filters.js
+++ b/src/filters.js
@@ -130,12 +130,4 @@ export function limitToValue(value) {
   return value
 }
 
-Vue.filter('limitToValue', limitToValue)
-
-export function transformUrlToHref(string) {
-  const expression = /(https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9]+\.[^\s]{2,}|www\.[a-zA-Z0-9]+\.[^\s]{2,})/gi
-
-  return string.replace(expression, '<a href="$1" target="_blank">$1</a>')
-}
-
-Vue.filter('transformUrlToHref', transformUrlToHref)
+Vue.filter('limitToValue', limitToValue)
\ No newline at end of file
diff --git a/src/helpers.js b/src/helpers.js
index 89ed9c81..997adb29 100644
--- a/src/helpers.js
+++ b/src/helpers.js
@@ -121,3 +121,37 @@ export function getHostName(url) {
     return ''
   }
 }
+
+const urlRegExp = new RegExp(/(https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9]+\.[^\s]{2,}|www\.[a-zA-Z0-9]+\.[^\s]{2,})/gi)
+
+export function splitByUrl(string) {
+  const urls = string.match(urlRegExp)
+  let resultArray = []
+
+  if (urls) {
+    urls.forEach(function (url) {
+      let tmpResult
+      if (resultArray.length === 0) {
+        tmpResult = string.toString().split(url)
+      } else {
+        tmpResult = resultArray[resultArray.length - 1].toString().split(url)
+        resultArray.pop()
+      }
+
+      tmpResult.splice(1, 0, url)
+      resultArray = [...resultArray, ...tmpResult]
+    })
+  } else {
+    resultArray[0] = string
+  }
+
+  resultArray = resultArray.filter(element => {
+    return element !== ''
+  })
+
+  return resultArray
+}
+
+export function stringContainsUrl(string) {
+  return urlRegExp.test(string)
+}
\ No newline at end of file
diff --git a/tests/unit/filters.spec.js b/tests/unit/filters.spec.js
index 84c40cd6..8da399c3 100644
--- a/tests/unit/filters.spec.js
+++ b/tests/unit/filters.spec.js
@@ -1,28 +1,8 @@
-import { titleCase, transformUrlToHref } from '../../src/filters'
+import { titleCase } from '../../src/filters'
 
 describe('Filters', () => {
   it('titleCase', () => {
     expect(titleCase('test')).toEqual('Test')
     expect(titleCase('hello there')).toEqual('Hello There')
   })
-
-  describe('transformUrlToHref()', () => {
-    it('should not transform anything', () => {
-      expect(transformUrlToHref('test')).toEqual('test')
-    })
-
-    it('should transform string where http/https is found', () => {
-      expect(transformUrlToHref('test http://test.something')).toEqual('test <a href="http://test.something" target="_blank">http://test.something</a>')
-      expect(transformUrlToHref('123456 test@345 https://something.else')).toEqual('123456 test@345 <a href="https://something.else" target="_blank">https://something.else</a>')
-    })
-
-    it('should transform string where only www is found', () => {
-      expect(transformUrlToHref('test www.test.something')).toEqual('test <a href="www.test.something" target="_blank">www.test.something</a>')
-    })
-
-    it('should transform string where both www and http/https are found', () => {
-      expect(transformUrlToHref('test http://www.test.something')).toEqual('test <a href="http://www.test.something" target="_blank">http://www.test.something</a>')
-      expect(transformUrlToHref('test https://www.something.else')).toEqual('test <a href="https://www.something.else" target="_blank">https://www.something.else</a>')
-    })
-  })
 })
\ No newline at end of file
diff --git a/tests/unit/helpers.spec.js b/tests/unit/helpers.spec.js
new file mode 100644
index 00000000..8fc339aa
--- /dev/null
+++ b/tests/unit/helpers.spec.js
@@ -0,0 +1,27 @@
+import { splitByUrl } from '../../src/helpers'
+
+describe('Helpers', () => {
+  describe('splitByUrl()', () => {
+    it('should not split anything', () => {
+      expect(splitByUrl('test')).toEqual(['test'])
+    })
+
+    it('should split to array if http/https is found', () => {
+      expect(splitByUrl('test http://test.something')).toEqual(['test ', 'http://test.something'])
+      expect(splitByUrl('123456 test@345 https://something.else test@@!!#789')).toEqual(['123456 test@345 ', 'https://something.else', ' test@@!!#789'])
+    })
+
+    it('should split to array if www is found', () => {
+      expect(splitByUrl('test www.test.something')).toEqual(['test ', 'www.test.something'])
+    })
+
+    it('should split to array where both www and http/https are found', () => {
+      expect(splitByUrl('test http://www.test.something')).toEqual(['test ', 'http://www.test.something'])
+      expect(splitByUrl('test https://www.something.else')).toEqual(['test ', 'https://www.something.else'])
+    })
+
+    it('should split correctly if more than one url exists', () => {
+      expect(splitByUrl('test http://www.test.something some string and https://onemoreurl.com')).toEqual(['test ', 'http://www.test.something', ' some string and ', 'https://onemoreurl.com'])
+    })
+  })
+})
\ No newline at end of file