Commit graph

315 commits

Author SHA1 Message Date
Benoit Marty
d8436874e2 Fix StaticFieldLeak issue (context).
Make VectorLocal an injectable class.
2022-09-22 16:32:14 +02:00
Benoit Marty
7e8a39e6de Suppress LaunchActivityFromNotification. This is fine here, this is the notification for the diagnostic, we do not want to start an Activity. 2022-09-22 16:32:14 +02:00
Benoit Marty
1ff4a5f212 Ignore AlwaysShowAction lint issue. Also make it an error, so that developer has to explicitly disable the warning. 2022-09-22 16:32:14 +02:00
Benoit Marty
b9c28ba4ce
Merge branch 'develop' into feature/bma/android12 2022-09-21 16:24:30 +02:00
bmarty
925fffac45 Sync Emojis 2022-09-19 00:03:51 +00:00
Benoit Marty
842a9bbd55 Add dataExtractionRules, applicable to Android 12. Exclude everything from being backed up. Also properly support Android 11. 2022-09-16 23:01:29 +02:00
bmarty
0c4707c315 Sync Emojis 2022-09-12 00:06:34 +00:00
Adam Brown
feb1a2a876 including vector-app in the code_quality script 2022-08-31 09:16:01 +01:00
Adam Brown
4d3e21d046 reusing lint file 2022-08-31 09:16:00 +01:00
Benoit Marty
5f0b26ae39 Remove FragmentModule 2022-08-23 18:47:23 +02:00
Benoit Marty
7883a6c617 Rename gl to gl-ES to be PlayStore compatible, and unignore this language. 2022-08-23 15:16:12 +02:00
Benoit Marty
8857decc87
Merge pull request #6701 from vector-im/sync-emojis
Sync Emojis
2022-08-17 16:32:55 +02:00
Benoit Marty
6ac88a9420 Add a check on suspicious string template.
Especially we want to ensure that the app does not log unexpected content.
2022-08-16 16:05:40 +02:00
Benoit Marty
1389262c3f Let danger check for frozen classes 2022-08-16 11:41:30 +02:00
Benoit Marty
08fff48065 Revert "Simple check to prevent frozen class modificaiton"
This reverts commit 28ca03cc67.
2022-08-16 11:14:01 +02:00
bmarty
ecfa7db07d Sync Emojis 2022-08-15 00:03:34 +00:00
Adam Brown
a2768ccab7 ignoring the gl locale from the play store upload step as it's unsupported 2022-08-09 16:22:21 +01:00
Michael Kaye
09a91c4541
Make it easier to find developer sign-off instructions (#6739)
* Make it easier to find sign-off instructions by linking directly to DCO docs from danger message.
2022-08-04 15:54:53 +01:00
Adam Brown
1497650146
Merge pull request #6715 from vector-im/feature/adm/danger-reviewers
Fix danger reviewers PR comment
2022-08-02 14:15:26 +01:00
Adam Brown
3fe7a9d8d5
Merge pull request #6588 from vector-im/dependabot/gradle/io.gitlab.arturbosch.detekt-1.21.0
Bump io.gitlab.arturbosch.detekt from 1.20.0 to 1.21.0
2022-08-02 12:56:45 +01:00
Adam Brown
c99f67bea4 reading users field from the reviews object for calculating if reviewers have been set 2022-08-02 12:34:36 +01:00
Adam Brown
ba5d6c9108 replacing all danger mutable lets with const 2022-08-02 12:19:16 +01:00
Adam Brown
7d120f94f6 reading the reviewers length from the github object as per the dsl 2022-08-02 12:17:48 +01:00
Benoit Marty
725ed00759 Change some severities 2022-07-29 15:41:36 +02:00
Benoit Marty
d60695806f Do not require a changelog file for PR created by Dependabot. 2022-07-29 15:18:04 +02:00
Benoit Marty
c41f0dd0cf Do not request PR created by Dependabot to include a Sign-off.
Dependabot includes a sign-off in its commits, but if the team adds extra commits, we will have the warning that a sign off is required.
2022-07-29 15:13:55 +02:00
Benoit Marty
56691f613e Setup Danger to Element Android project. 2022-07-29 10:02:40 +02:00
Benoit Marty
a52a2504ef We do not use TravisCI anymore. 2022-07-29 10:02:40 +02:00
Benoit Marty
2d761385a1 Detekt: disable rule UseCheckOrError 2022-07-19 15:02:21 +02:00
Benoit Marty
b4f833cb0d Detekt: disable rule InstanceOfCheckForException 2022-07-19 15:02:21 +02:00
Benoit Marty
7616912411
Merge pull request #6436 from vector-im/feature/bma/activity_fragment_1_5_0
Upgrade androidx activity and fragment to 1.5.0
2022-07-06 11:44:22 +02:00
Benoit Marty
aae6e20f9c Migration to activity 1.5.0. Rework menu management 2022-07-01 17:06:02 +02:00
Valere
28ca03cc67 Simple check to prevent frozen class modificaiton 2022-07-01 11:54:30 +02:00
Benoit Marty
ba8fcf9de3 Suppress issue on a tool. 2022-06-17 12:17:09 +02:00
Benoit Marty
5b185152c6 Remove non needed extra spaces: add a check 2022-05-20 09:48:05 +02:00
Benoit Marty
e00a9278d5 Detekt: Enable OutdatedDocumentation 2022-05-20 09:47:54 +02:00
Benoit Marty
12644e9915
Merge pull request #5947 from vector-im/feature/bma/renaming
Small changes
2022-05-18 16:27:48 +02:00
Benoit Marty
4c95aafe10 Detekt: enable and fix EndOfSentenceFormat 2022-05-16 08:54:07 +02:00
Benoit Marty
cf3e34e548 Detekt: add rules about comment 2022-05-13 09:51:14 +02:00
Benoit Marty
b70bc20b99 This is now detected by detekt 2022-05-12 22:53:07 +02:00
Benoit Marty
03ec9946ff Detekt: fix ConstructorParameterNaming
UserProperties fix is also in https://github.com/matrix-org/matrix-analytics-events/pull/62
2022-05-12 22:17:56 +02:00
Benoit Marty
6f3b9c78b0 Detekt: fix FunctionParameterNaming 2022-05-12 17:56:05 +02:00
Benoit Marty
c303b9afd3 Ignore more rules 2022-05-12 17:54:30 +02:00
Benoit Marty
c5f9546605 Ignore more rules 2022-05-12 17:23:41 +02:00
Benoit Marty
824f029e20 "TODO:" is forbidden by Detekt 2022-05-12 17:06:52 +02:00
Benoit Marty
7d6c27eed5 Ignore rule 2022-05-12 17:05:19 +02:00
Benoit Marty
9834371e18 Detekt: configure and ignore some rules. 2022-05-12 16:56:49 +02:00
Benoit Marty
c02fb87bc9 Set up detekt gradle plugin 2022-05-12 16:41:36 +02:00
Benoit Marty
8e319067ad Add diag request for Synapse 2022-05-05 15:34:23 +02:00
Benoit Marty
133d1972a3 Check more modules 2022-05-05 15:03:59 +02:00
Benoit Marty
32bc93c87d Ensure the Clock interface is used. 2022-05-03 15:02:34 +02:00
Benoit Marty
c8aefd5828 Update issue hint 2022-04-13 13:42:15 +02:00
Benoit Marty
f4fba2dd2d Check usage of import org.matrix.android.sdk.internal app side 2022-04-12 15:38:20 +02:00
Benoit Marty
1a53d2c8da python3 2022-04-07 09:30:52 +02:00
Benoit Marty
4d19d0370d matrix-sdk-android-rx module has been replaced by matrix-sdk-android-flow 2022-04-06 14:34:23 +02:00
Benoit Marty
963b2dfa57 Ignore false positive on static analysis tools
Until 2023-01-01Z !
2022-03-29 19:38:10 +02:00
Benoit Marty
587948c1b9 Bump Jitsi lib from 5.0.1 to 5.0.2
https://github.com/jitsi/jitsi-meet-release-notes/blob/master/CHANGELOG-MOBILE-SDKS.md#502-2022-03-29
2022-03-29 18:24:44 +02:00
Benoit Marty
0d2d1339e0 Bump Jitsi lib from 3.10.0 to 5.0.1 2022-03-29 16:29:35 +02:00
Benoit Marty
2055e7a27d Add link to the changelog 2022-03-29 15:48:53 +02:00
Benoit Marty
03fee2a131 The .exhaustive trick is not needed anymore in Kotlin 1.6.0
https://kotlinlang.org/docs/whatsnew16.html#stable-exhaustive-when-statements-for-enum-sealed-and-boolean-subjects
2022-03-22 16:14:15 +01:00
Michael Kaye
4a8aeadbcf
Merge pull request #5471 from vector-im/michaelk/ci_script_improvements
CI Script improvements
2022-03-21 15:06:11 +00:00
bmarty
ffb007e96d Sync Emojis 2022-03-21 00:03:12 +00:00
Michael Kaye
314f32ed45 If a FileNotFound exception occurs, log a simple message indicating the tests may
have not run.
2022-03-10 10:24:41 +00:00
Michael Kaye
2d5b25cfad Remove the printing of file name to the log as it's doubling up information. 2022-03-03 20:39:41 +00:00
Michael Kaye
7837d1d6d6 Wrap up the argument list; it can be long 2022-03-02 10:05:07 +00:00
Michael Kaye
0ce59989a5 Log xml files we render.
We seem to be missing some tests here (?)
2022-02-25 11:07:03 +00:00
Michael Kaye
9ddcaffebf Adjust script to handle XML files 2022-02-24 16:36:43 +00:00
Michael Kaye
70c9418a5e Fix typo in script 2022-02-24 14:48:03 +00:00
Michael Kaye
4d86f5f2fd Correct name of script 2022-02-24 14:48:02 +00:00
Michael Kaye
fbf29f6f1e Quick hack python to render the xml test output including times in a easy to read format. 2022-02-24 14:47:23 +00:00
Michael Kaye
779b5db363 Add a python script to cleanly display outputs in the github logs 2022-02-24 14:46:31 +00:00
Ahmed Radhouane Belkilani
91ab4726ad #3296
- Fixes after review.

Signed-off-by: Ahmed Radhouane Belkilani <arbelkilani@gmail.com>
2022-02-23 11:34:43 +01:00
bmarty
ff1c307ca0 Sync Emojis 2022-02-14 00:03:37 +00:00
ariskotsomitopoulos
b2a2fe2710 Merge branch 'develop' into feature/aris/threads
# Conflicts:
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/relation/RelationService.kt
#	tools/check/forbidden_strings_in_code.txt
#	vector/build.gradle
#	vector/src/main/java/im/vector/app/core/di/FragmentModule.kt
#	vector/src/main/java/im/vector/app/core/resources/UserPreferencesProvider.kt
#	vector/src/main/java/im/vector/app/features/command/Command.kt
#	vector/src/main/java/im/vector/app/features/command/CommandParser.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailViewState.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/TimelineViewModel.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/composer/MessageComposerViewModel.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/search/SearchResultItem.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/timeline/TimelineEventController.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/timeline/factory/MessageItemFactory.kt
#	vector/src/main/java/im/vector/app/features/navigation/Navigator.kt
#	vector/src/main/java/im/vector/app/features/notifications/NotificationUtils.kt
#	vector/src/main/java/im/vector/app/features/settings/VectorPreferences.kt
#	vector/src/main/res/layout/fragment_timeline.xml
#	vector/src/main/res/xml/vector_settings_labs.xml
2022-01-27 17:11:26 +02:00
Benoit Marty
76599af088 Add default description for nl-NL 2022-01-25 19:05:20 +01:00
Benoit Marty
17de88e5f6 Remove the check on number of enum class.
Now that we have more developers, we can have conflict because ot the number of exception. Let's hope we will not do the mistake...
2022-01-24 18:12:41 +01:00
Benoit Marty
58197b8853 Fix enum class warning 2022-01-20 15:37:57 +01:00
ariskotsomitopoulos
3bd21d04d8 Merge branch 'develop' into feature/aris/threads
# Conflicts:
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/TokenChunkEventPersistor.kt
#	tools/check/forbidden_strings_in_code.txt
2022-01-11 14:09:49 +02:00
Valere
3f0122be01 Update nb of enum classes 2022-01-10 09:44:11 +01:00
ariskotsomitopoulos
ac5caccdf9 Merge branch 'develop' into feature/aris/threads
# Conflicts:
#	matrix-sdk-android/src/androidTest/java/org/matrix/android/sdk/common/CommonTestHelper.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/RealmSessionStoreMigration.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/model/EventEntity.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/DefaultTimeline.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/TokenChunkEventPersistor.kt
#	matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt
#	tools/check/forbidden_strings_in_code.txt
#	vector/src/main/java/im/vector/app/features/home/room/detail/RoomDetailViewModel.kt
#	vector/src/main/java/im/vector/app/features/home/room/detail/TimelineFragment.kt
#	vector/src/main/res/menu/menu_timeline.xml
2022-01-07 13:29:43 +02:00
Adam Brown
12abd3b019 updating enum class counter 2022-01-06 10:25:41 +00:00
Benoit Marty
48e15b1c36 Restore line deleted during GitHub conflict fixing by mistake 2022-01-04 16:15:25 +01:00
Benoit Marty
7bbea52e66
Merge branch 'develop' into feature/bma/math_final 2022-01-04 16:13:23 +01:00
Benoit Marty
2dc88d1477 Fix code quality 2022-01-03 20:22:57 +01:00
Benoit Marty
b39caeb04d 2 new enums 2022-01-03 15:27:59 +01:00
ariskotsomitopoulos
0d9bc188d7 Fix code quality issues 2021-12-26 00:48:11 +02:00
Benoit Marty
4949a06343 Use stable build tools for the release. 2021-12-14 16:37:52 +01:00
Benoit Marty
be33a53e56 code quality 2021-12-14 09:06:43 +01:00
Benoit Marty
a40e60ba8f Merge branch 'develop' into feature/bma/posthog 2021-12-13 23:18:14 +01:00
Benoit Marty
d3a1746475 Use id from existing views instead of "hard-coded" values
And improve our extension
2021-12-07 16:56:27 +01:00
Benoit Marty
673cbb29de Merge branch 'develop' into feature/bma/posthog 2021-12-07 14:26:31 +01:00
Benoit Marty
88605b65b7
Merge pull request #4628 from vector-im/feature/bma/compressVideo
Add script to compress video and convert to gif file
2021-12-03 18:13:20 +01:00
Benoit Marty
b2dce51fc2 Add script to compress video and convert to gif file 2021-12-03 17:30:30 +01:00
Adam Brown
6a3d4044ef removing unused imports and increasing enum allowance 2021-12-03 15:30:55 +00:00
Benoit Marty
055c9be9ce Add a script to import the plan to Element-Android project 2021-12-02 14:10:03 +01:00
Benoit Marty
6cb8a2458f Remove extra new lines in XML 2021-12-01 23:06:49 +01:00
Benoit Marty
6624039413 Use @id and not @+id when referencing ids in layouts - RelativeLayout and toolbarId 2021-12-01 22:44:07 +01:00
Benoit Marty
e106ff8de0 Use @id and not @+id when referencing ids in layouts - ConstraintLayout 2021-12-01 22:19:33 +01:00
Benoit Marty
2d17156861 Use @id and not @+id when referencing ids in layouts - accessibilityTraversal 2021-12-01 22:16:28 +01:00
Benoit Marty
6d3df0d802 Use @id and not @+id when referencing ids in layouts - ConstraintLayout 2021-12-01 22:13:21 +01:00