From f90ee45d8caabd25e67d9ce13498bcbb0dc54190 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Mon, 14 Jun 2021 23:03:37 +0200 Subject: [PATCH] Use style to take into account `lineHeight` --- .../layout/activity_test_material_theme.xml | 4 +- .../res/layout/debug_text_appearance.xml | 74 ------------------- .../src/debug/res/layout/debug_text_view.xml | 68 +++++++++++++++++ .../src/debug/res/layout/item_sas_emoji.xml | 6 +- .../main/res/layout/activity_bug_report.xml | 2 +- vector/src/main/res/layout/activity_call.xml | 2 +- .../main/res/layout/activity_signed_out.xml | 4 +- .../res/layout/activity_simple_loading.xml | 1 - .../layout/alerter_incoming_call_layout.xml | 4 +- .../layout/alerter_verification_layout.xml | 6 +- .../bottom_sheet_generic_list_with_title.xml | 2 +- .../layout/bottom_sheet_invited_to_space.xml | 4 +- .../layout/bottom_sheet_logout_and_backup.xml | 2 +- .../bottom_sheet_room_widget_permission.xml | 8 +- .../res/layout/bottom_sheet_space_invite.xml | 4 +- .../bottom_sheet_space_invite_chooser.xml | 2 +- .../layout/bottom_sheet_space_settings.xml | 4 +- .../res/layout/dialog_disclaimer_content.xml | 2 +- .../main/res/layout/dialog_event_content.xml | 4 +- .../res/layout/dialog_export_e2e_keys.xml | 2 +- .../res/layout/dialog_import_e2e_keys.xml | 2 +- .../layout/dialog_recovery_key_saved_info.xml | 2 +- .../layout/fragment_bootstrap_conclusion.xml | 2 +- ...gment_bootstrap_enter_account_password.xml | 2 +- .../fragment_bootstrap_enter_passphrase.xml | 4 +- .../fragment_bootstrap_migrate_backup.xml | 2 +- .../res/layout/fragment_bootstrap_reauth.xml | 4 +- .../layout/fragment_bootstrap_save_key.xml | 4 +- .../fragment_bootstrap_setup_recovery.xml | 4 +- .../res/layout/fragment_bootstrap_waiting.xml | 4 +- .../res/layout/fragment_contacts_book.xml | 2 +- ...ent_create_direct_room_directory_users.xml | 2 +- .../main/res/layout/fragment_create_room.xml | 2 +- .../layout/fragment_devtool_keyrequests.xml | 18 ++--- .../main/res/layout/fragment_home_detail.xml | 4 +- .../main/res/layout/fragment_home_drawer.xml | 8 +- .../fragment_keys_backup_restore_from_key.xml | 2 +- ...nt_keys_backup_restore_from_passphrase.xml | 2 +- .../fragment_keys_backup_restore_success.xml | 2 +- .../fragment_keys_backup_setup_step1.xml | 2 +- .../fragment_keys_backup_setup_step2.xml | 2 +- .../fragment_keys_backup_setup_step3.xml | 4 +- vector/src/main/res/layout/fragment_login.xml | 8 +- .../layout/fragment_login_account_created.xml | 16 ++-- ...fragment_login_generic_text_input_form.xml | 6 +- ...agment_login_generic_text_input_form_2.xml | 8 +- .../layout/fragment_login_reset_password.xml | 4 +- .../fragment_login_reset_password_2.xml | 8 +- ...login_reset_password_mail_confirmation.xml | 6 +- ...gin_reset_password_mail_confirmation_2.xml | 6 +- .../fragment_login_reset_password_success.xml | 6 +- ...ragment_login_reset_password_success_2.xml | 6 +- .../fragment_login_server_selection.xml | 14 ++-- .../fragment_login_server_selection_2.xml | 14 ++-- .../layout/fragment_login_server_url_form.xml | 10 +-- .../fragment_login_server_url_form_2.xml | 4 +- .../fragment_login_signin_password_2.xml | 6 +- .../layout/fragment_login_signin_to_any_2.xml | 4 +- .../fragment_login_signin_username_2.xml | 6 +- .../fragment_login_signup_password_2.xml | 10 +-- ...fragment_login_signup_signin_selection.xml | 6 +- .../fragment_login_signup_username_2.xml | 8 +- .../main/res/layout/fragment_login_splash.xml | 8 +- .../res/layout/fragment_login_splash_2.xml | 8 +- .../res/layout/fragment_login_sso_only_2.xml | 2 +- .../res/layout/fragment_login_terms_2.xml | 2 +- .../layout/fragment_login_wait_for_email.xml | 4 +- .../fragment_login_wait_for_email_2.xml | 6 +- .../res/layout/fragment_matrix_profile.xml | 2 +- .../fragment_matrix_to_room_space_card.xml | 8 +- .../layout/fragment_matrix_to_user_card.xml | 4 +- .../res/layout/fragment_qr_code_scanner.xml | 44 +++++------ .../res/layout/fragment_reauth_confirm.xml | 6 +- .../fragment_recyclerview_with_search.xml | 4 +- .../main/res/layout/fragment_room_detail.xml | 2 +- .../fragment_room_preview_no_preview.xml | 10 +-- .../layout/fragment_room_setting_generic.xml | 2 +- .../main/res/layout/fragment_room_uploads.xml | 2 +- .../layout/fragment_set_identity_server.xml | 4 +- .../res/layout/fragment_space_add_rooms.xml | 4 +- ...ment_space_create_choose_private_model.xml | 2 +- .../fragment_space_create_choose_type.xml | 6 +- .../res/layout/fragment_space_preview.xml | 2 +- .../layout/fragment_ssss_access_from_key.xml | 2 +- .../fragment_ssss_access_from_passphrase.xml | 4 +- .../res/layout/fragment_ssss_reset_all.xml | 4 +- .../res/layout/fragment_user_code_show.xml | 8 +- .../res/layout/fragment_user_directory.xml | 2 +- .../main/res/layout/fragment_user_list.xml | 4 +- .../res/layout/item_autocomplete_command.xml | 6 +- .../res/layout/item_autocomplete_emoji.xml | 4 +- .../layout/item_autocomplete_matrix_item.xml | 4 +- .../layout/item_autocomplete_more_result.xml | 2 +- .../item_bottom_sheet_message_preview.xml | 8 +- .../item_bottom_sheet_message_status.xml | 4 +- .../res/layout/item_bottom_sheet_radio.xml | 4 +- .../layout/item_bottom_sheet_room_preview.xml | 2 +- .../res/layout/item_bottom_sheet_title.xml | 4 +- .../res/layout/item_completion_homeserver.xml | 2 +- .../main/res/layout/item_contact_action.xml | 2 +- .../main/res/layout/item_contact_detail.xml | 4 +- .../src/main/res/layout/item_contact_main.xml | 2 +- .../layout/item_create_direct_room_user.xml | 4 +- vector/src/main/res/layout/item_device.xml | 8 +- .../src/main/res/layout/item_emoji_result.xml | 2 +- .../res/layout/item_expandable_textview.xml | 2 +- .../res/layout/item_form_advanced_toggle.xml | 2 +- .../src/main/res/layout/item_form_switch.xml | 4 +- .../main/res/layout/item_generic_button.xml | 8 +- .../res/layout/item_generic_empty_state.xml | 4 +- .../main/res/layout/item_generic_header.xml | 2 +- .../res/layout/item_generic_with_value.xml | 4 +- vector/src/main/res/layout/item_group.xml | 2 +- .../src/main/res/layout/item_help_footer.xml | 2 +- .../src/main/res/layout/item_known_user.xml | 4 +- vector/src/main/res/layout/item_loading.xml | 2 +- vector/src/main/res/layout/item_locale.xml | 2 +- .../src/main/res/layout/item_login_text.xml | 2 +- .../src/main/res/layout/item_login_title.xml | 2 +- .../res/layout/item_login_title_small.xml | 2 +- .../layout/item_notification_troubleshoot.xml | 2 +- .../main/res/layout/item_profile_action.xml | 4 +- .../res/layout/item_profile_matrix_item.xml | 6 +- .../item_profile_matrix_item_progress.xml | 4 +- .../main/res/layout/item_profile_section.xml | 10 +-- .../src/main/res/layout/item_public_room.xml | 6 +- .../src/main/res/layout/item_pushgateway.xml | 4 +- vector/src/main/res/layout/item_room.xml | 10 +-- .../res/layout/item_room_alias_text_input.xml | 4 +- .../main/res/layout/item_room_category.xml | 4 +- .../main/res/layout/item_room_directory.xml | 4 +- .../res/layout/item_room_directory_server.xml | 4 +- .../res/layout/item_room_filter_footer.xml | 2 +- .../main/res/layout/item_room_invitation.xml | 4 +- .../res/layout/item_room_to_add_in_space.xml | 2 +- .../layout/item_room_to_manage_in_space.xml | 4 +- .../main/res/layout/item_search_result.xml | 4 +- .../item_settings_button_single_line.xml | 2 +- .../res/layout/item_settings_edit_text.xml | 2 +- .../res/layout/item_settings_helper_info.xml | 2 +- .../res/layout/item_settings_information.xml | 2 +- .../layout/item_settings_section_title.xml | 2 +- .../res/layout/item_settings_simple_item.xml | 4 +- .../res/layout/item_settings_three_pid.xml | 2 +- .../res/layout/item_simple_reaction_info.xml | 2 +- vector/src/main/res/layout/item_space.xml | 6 +- vector/src/main/res/layout/item_space_add.xml | 2 +- .../res/layout/item_space_beta_header.xml | 6 +- .../main/res/layout/item_space_roomchild.xml | 4 +- .../main/res/layout/item_space_subspace.xml | 2 +- .../res/layout/item_space_top_summary.xml | 2 +- vector/src/main/res/layout/item_sub_space.xml | 4 +- .../main/res/layout/item_suggested_room.xml | 4 +- .../res/layout/item_timeline_event_base.xml | 4 +- .../item_timeline_event_base_noinfo.xml | 2 +- .../item_timeline_event_call_tile_stub.xml | 6 +- .../item_timeline_event_code_block_stub.xml | 4 +- .../res/layout/item_timeline_event_create.xml | 4 +- .../item_timeline_event_day_separator.xml | 2 +- .../item_timeline_event_default_stub.xml | 2 +- ...item_timeline_event_merged_header_stub.xml | 4 +- ...meline_event_merged_room_creation_stub.xml | 8 +- .../item_timeline_event_merged_utd_stub.xml | 6 +- .../item_timeline_event_notice_stub.xml | 2 +- ...tem_timeline_event_option_buttons_stub.xml | 2 +- .../layout/item_timeline_event_poll_stub.xml | 4 +- .../item_timeline_event_redacted_stub.xml | 2 +- .../item_timeline_event_status_tile_stub.xml | 4 +- .../item_timeline_event_text_message_stub.xml | 2 +- .../item_timeline_event_verification_stub.xml | 6 +- .../item_timeline_event_widget_stub.xml | 2 +- .../res/layout/item_timeline_read_marker.xml | 2 +- .../src/main/res/layout/item_unknown_room.xml | 2 +- .../src/main/res/layout/item_uploads_file.xml | 4 +- vector/src/main/res/layout/item_user.xml | 4 +- .../res/layout/item_verification_action.xml | 4 +- .../res/layout/item_verification_notice.xml | 2 +- .../res/layout/item_verification_wait.xml | 2 +- .../res/layout/item_verification_waiting.xml | 2 +- .../media_upload_download_progress_layout.xml | 2 +- .../layout/merge_image_attachment_overlay.xml | 4 +- .../src/main/res/layout/reaction_button.xml | 4 +- .../vector_home_badge_unread_layout.xml | 2 +- .../main/res/layout/vector_invite_view.xml | 6 +- .../view_bottom_sheet_action_button.xml | 4 +- .../main/res/layout/view_current_calls.xml | 4 +- .../layout/view_failed_messages_warning.xml | 4 +- .../res/layout/view_keys_backup_banner.xml | 4 +- .../main/res/layout/view_poll_result_line.xml | 4 +- .../src/main/res/layout/view_read_marker.xml | 2 +- .../main/res/layout/view_read_receipts.xml | 2 +- .../res/layout/view_room_widgets_banner.xml | 2 +- .../res/layout/view_space_type_button.xml | 4 +- vector/src/main/res/layout/view_state.xml | 6 +- .../view_stub_room_member_profile_header.xml | 6 +- .../layout/view_stub_room_profile_header.xml | 2 +- .../src/main/res/layout/view_url_preview.xml | 6 +- vector/src/main/res/values/styles_buttons.xml | 8 ++ .../src/main/res/values/styles_text_view.xml | 41 +++++++++- .../src/main/res/values/text_appearances.xml | 7 +- vector/src/main/res/values/theme_dark.xml | 2 +- vector/src/main/res/values/theme_light.xml | 2 +- 202 files changed, 542 insertions(+), 503 deletions(-) delete mode 100644 vector/src/debug/res/layout/debug_text_appearance.xml create mode 100644 vector/src/debug/res/layout/debug_text_view.xml diff --git a/vector/src/debug/res/layout/activity_test_material_theme.xml b/vector/src/debug/res/layout/activity_test_material_theme.xml index 07b54ec0dd..c228377b98 100644 --- a/vector/src/debug/res/layout/activity_test_material_theme.xml +++ b/vector/src/debug/res/layout/activity_test_material_theme.xml @@ -444,10 +444,10 @@ + android:text="Text views" /> diff --git a/vector/src/debug/res/layout/debug_text_appearance.xml b/vector/src/debug/res/layout/debug_text_appearance.xml deleted file mode 100644 index 39db326618..0000000000 --- a/vector/src/debug/res/layout/debug_text_appearance.xml +++ /dev/null @@ -1,74 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/vector/src/debug/res/layout/debug_text_view.xml b/vector/src/debug/res/layout/debug_text_view.xml new file mode 100644 index 0000000000..7e922fe741 --- /dev/null +++ b/vector/src/debug/res/layout/debug_text_view.xml @@ -0,0 +1,68 @@ + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/vector/src/debug/res/layout/item_sas_emoji.xml b/vector/src/debug/res/layout/item_sas_emoji.xml index be68af6021..94e0689b1f 100644 --- a/vector/src/debug/res/layout/item_sas_emoji.xml +++ b/vector/src/debug/res/layout/item_sas_emoji.xml @@ -12,11 +12,11 @@ @@ -36,19 +36,19 @@ diff --git a/vector/src/main/res/layout/activity_bug_report.xml b/vector/src/main/res/layout/activity_bug_report.xml index 4736ec667e..840a3439d9 100644 --- a/vector/src/main/res/layout/activity_bug_report.xml +++ b/vector/src/main/res/layout/activity_bug_report.xml @@ -91,12 +91,12 @@