From 3c57916ec3b0e127681064f1aa793bff51e00ae1 Mon Sep 17 00:00:00 2001 From: Maxime NATUREL Date: Wed, 13 Apr 2022 10:55:59 +0200 Subject: [PATCH 1/5] Adding changelog entry --- changelog.d/5751.feature | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/5751.feature diff --git a/changelog.d/5751.feature b/changelog.d/5751.feature new file mode 100644 index 0000000000..8c69bd2593 --- /dev/null +++ b/changelog.d/5751.feature @@ -0,0 +1 @@ +[Location sharing] - Disable live location sharing by default From 9d2c704aef9b5c13eb1c1365502db010b8f7a84c Mon Sep 17 00:00:00 2001 From: Maxime NATUREL Date: Wed, 13 Apr 2022 10:56:20 +0200 Subject: [PATCH 2/5] Removing the BuildConfigField --- vector/build.gradle | 2 -- vector/src/main/java/im/vector/app/features/VectorFeatures.kt | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/vector/build.gradle b/vector/build.gradle index 52132ee074..c7950da28e 100644 --- a/vector/build.gradle +++ b/vector/build.gradle @@ -229,7 +229,6 @@ android { buildConfigField "boolean", "LOW_PRIVACY_LOG_ENABLE", "false" // Set to true if you want to enable strict mode in debug buildConfigField "boolean", "ENABLE_STRICT_MODE_LOGS", "false" - buildConfigField "Boolean", "ENABLE_LIVE_LOCATION_SHARING", "true" signingConfig signingConfigs.debug } @@ -239,7 +238,6 @@ android { buildConfigField "boolean", "LOW_PRIVACY_LOG_ENABLE", "false" buildConfigField "boolean", "ENABLE_STRICT_MODE_LOGS", "false" - buildConfigField "Boolean", "ENABLE_LIVE_LOCATION_SHARING", "false" postprocessing { removeUnusedCode true diff --git a/vector/src/main/java/im/vector/app/features/VectorFeatures.kt b/vector/src/main/java/im/vector/app/features/VectorFeatures.kt index 992fa4d5a5..b2a62a42d3 100644 --- a/vector/src/main/java/im/vector/app/features/VectorFeatures.kt +++ b/vector/src/main/java/im/vector/app/features/VectorFeatures.kt @@ -42,5 +42,5 @@ class DefaultVectorFeatures : VectorFeatures { override fun isOnboardingUseCaseEnabled() = true override fun isOnboardingPersonalizeEnabled() = false override fun isOnboardingCombinedRegisterEnabled() = false - override fun isLiveLocationEnabled(): Boolean = BuildConfig.ENABLE_LIVE_LOCATION_SHARING + override fun isLiveLocationEnabled(): Boolean = false } From a0ca8b6a1306d251290937689a1767e43c06e1e4 Mon Sep 17 00:00:00 2001 From: Maxime NATUREL Date: Wed, 13 Apr 2022 11:09:08 +0200 Subject: [PATCH 3/5] Using misc suffix for changelog entry --- changelog.d/{5751.feature => 5751.misc} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename changelog.d/{5751.feature => 5751.misc} (100%) diff --git a/changelog.d/5751.feature b/changelog.d/5751.misc similarity index 100% rename from changelog.d/5751.feature rename to changelog.d/5751.misc From 2d3a8b4d578d06b08631b50ff5d55122e03008c2 Mon Sep 17 00:00:00 2001 From: Maxime NATUREL Date: Wed, 13 Apr 2022 14:41:20 +0200 Subject: [PATCH 4/5] Adding details into changelog entry --- changelog.d/5751.misc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.d/5751.misc b/changelog.d/5751.misc index 8c69bd2593..3a8adec39f 100644 --- a/changelog.d/5751.misc +++ b/changelog.d/5751.misc @@ -1 +1 @@ -[Location sharing] - Disable live location sharing by default +[Location sharing] - Disable live location sharing by default in debug config From ea4515f90ec7714be74c953120280bf986ed9d25 Mon Sep 17 00:00:00 2001 From: Maxime NATUREL Date: Wed, 13 Apr 2022 14:44:43 +0200 Subject: [PATCH 5/5] Deleting changelog entry --- changelog.d/5751.misc | 1 - 1 file changed, 1 deletion(-) delete mode 100644 changelog.d/5751.misc diff --git a/changelog.d/5751.misc b/changelog.d/5751.misc deleted file mode 100644 index 3a8adec39f..0000000000 --- a/changelog.d/5751.misc +++ /dev/null @@ -1 +0,0 @@ -[Location sharing] - Disable live location sharing by default in debug config