From c0b01dff705ccf777adcd951f8b94e09db56fe3a Mon Sep 17 00:00:00 2001 From: Valere Date: Tue, 14 Sep 2021 15:25:40 +0200 Subject: [PATCH] code review --- .../spaces/create/CreateSpaceAdd3pidInvitesFragment.kt | 7 +++++++ .../app/features/spaces/create/CreateSpaceViewModel.kt | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceAdd3pidInvitesFragment.kt b/vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceAdd3pidInvitesFragment.kt index 98b04dde7c..6dc3ad8c21 100644 --- a/vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceAdd3pidInvitesFragment.kt +++ b/vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceAdd3pidInvitesFragment.kt @@ -22,6 +22,7 @@ import android.view.View import android.view.ViewGroup import com.airbnb.mvrx.activityViewModel import im.vector.app.R +import im.vector.app.core.extensions.cleanup import im.vector.app.core.extensions.configureWith import im.vector.app.core.extensions.hideKeyboard import im.vector.app.core.platform.OnBackPressed @@ -70,6 +71,12 @@ class CreateSpaceAdd3pidInvitesFragment @Inject constructor( } } + override fun onDestroyView() { + views.recyclerView.cleanup() + epoxyController.listener = null + super.onDestroyView() + } + override fun getBinding(inflater: LayoutInflater, container: ViewGroup?) = FragmentSpaceCreateGenericEpoxyFormBinding.inflate(layoutInflater, container, false) diff --git a/vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModel.kt b/vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModel.kt index b233469383..64209127b4 100644 --- a/vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModel.kt +++ b/vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModel.kt @@ -85,7 +85,7 @@ class CreateSpaceViewModel @AssistedInject constructor( } private fun stopListenToIdentityManager() { - identityService.addListener(identityServerManagerListener) + identityService.removeListener(identityServerManagerListener) } override fun onCleared() {