code review

This commit is contained in:
Valere 2023-10-03 11:29:50 +02:00
parent 87df8ab6f6
commit a015eda72c
2 changed files with 5 additions and 9 deletions

View file

@ -218,8 +218,8 @@ class Rendezvous(
Timber.tag(TAG).i("No master key given by verifying device")
}
// request secrets from the verifying device
Timber.tag(TAG).i("Requesting secrets from $verifyingDeviceId")
// request secrets from other sessions.
Timber.tag(TAG).i("Requesting secrets from other sessions")
session.sharedSecretStorageService().requestMissingSecrets()
} else {

View file

@ -28,13 +28,9 @@ internal class SecretShareManager @Inject constructor(
private val outgoingRequestsProcessor: OutgoingRequestsProcessor) {
suspend fun requestSecretTo(deviceId: String, secretName: String) {
Timber.v("SecretShareManager requesting $deviceId, $secretName")
if (this.olmMachine.get().requestMissingSecretsFromOtherSessions()) {
// immediately send the requests
outgoingRequestsProcessor.processOutgoingRequests(this.olmMachine.get()) {
it is Request.ToDevice && it.eventType == EventType.REQUEST_SECRET
}
}
Timber.w("SecretShareManager requesting custom secrets not supported $deviceId, $secretName")
// rust stack only support requesting secrets defined in the spec (not custom secret yet)
requestMissingSecrets()
}
suspend fun requestMissingSecrets() {