diff --git a/CHANGES.md b/CHANGES.md index 2111d369e9..54a0194a6d 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -23,7 +23,7 @@ SDK API changes ⚠️: - Rename package `im.vector.matrix.rx` to `org.matrix.android.sdk.rx` Build 🧱: - - + - Fix RtlHardcoded issues (use `Start` and `End` instead of `Left` and `Right` layout attributes) Other changes: - Use `Context#getSystemService` extension function provided by `core-ktx` (#1702) diff --git a/vector/lint.xml b/vector/lint.xml index 8acd8af9b6..86fc15f937 100644 --- a/vector/lint.xml +++ b/vector/lint.xml @@ -30,8 +30,7 @@ - - + diff --git a/vector/src/main/res/layout/activity_bug_report.xml b/vector/src/main/res/layout/activity_bug_report.xml index 7156f91314..3bfb1f5429 100644 --- a/vector/src/main/res/layout/activity_bug_report.xml +++ b/vector/src/main/res/layout/activity_bug_report.xml @@ -25,10 +25,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginTop="10dp" android:layout_marginEnd="10dp" - android:layout_marginRight="10dp" android:text="@string/send_bug_report_progress" android:textColor="?riotx_text_primary" android:visibility="gone" @@ -41,9 +39,7 @@ android:layout_height="20dp" android:layout_gravity="center_vertical" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginEnd="10dp" - android:layout_marginRight="10dp" android:max="100" android:visibility="gone" tools:progress="70" @@ -66,9 +62,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginEnd="10dp" - android:layout_marginRight="10dp" android:text="@string/send_bug_report_description" android:textColor="?riotx_text_primary" /> @@ -78,10 +72,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginTop="10dp" android:layout_marginEnd="10dp" - android:layout_marginRight="10dp" android:hint="@string/send_bug_report_placeholder" android:textColorHint="?attr/vctr_default_text_hint_color" app:counterEnabled="true" @@ -100,9 +92,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginEnd="10dp" - android:layout_marginRight="10dp" android:text="@string/send_bug_report_description_in_english" android:textColor="?riotx_text_secondary" android:textSize="12sp" /> @@ -112,10 +102,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginTop="10dp" android:layout_marginEnd="10dp" - android:layout_marginRight="10dp" android:text="@string/send_bug_report_logs_description" android:textColor="?riotx_text_primary" /> @@ -124,9 +112,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginEnd="10dp" - android:layout_marginRight="10dp" android:checked="true" android:text="@string/send_bug_report_include_logs" /> @@ -135,9 +121,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginEnd="10dp" - android:layout_marginRight="10dp" android:checked="true" android:text="@string/send_bug_report_include_crash_logs" /> @@ -146,9 +130,7 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginEnd="10dp" - android:layout_marginRight="10dp" android:checked="true" android:text="@string/send_bug_report_include_screenshot" /> diff --git a/vector/src/main/res/layout/alerter_verification_layout.xml b/vector/src/main/res/layout/alerter_verification_layout.xml index 7098c3152d..7a2e81a6ce 100644 --- a/vector/src/main/res/layout/alerter_verification_layout.xml +++ b/vector/src/main/res/layout/alerter_verification_layout.xml @@ -23,11 +23,11 @@ android:id="@+id/ivIcon" android:layout_width="24dp" android:layout_height="24dp" + android:src="@drawable/ic_shield_warning" app:layout_constraintCircle="@+id/ivUserAvatar" app:layout_constraintCircleAngle="135" app:layout_constraintCircleRadius="20dp" tools:ignore="MissingConstraints" - android:src="@drawable/ic_shield_warning" tools:visibility="visible" /> diff --git a/vector/src/main/res/layout/bottom_sheet_logout_and_backup.xml b/vector/src/main/res/layout/bottom_sheet_logout_and_backup.xml index 28262cf5de..c109e821cb 100644 --- a/vector/src/main/res/layout/bottom_sheet_logout_and_backup.xml +++ b/vector/src/main/res/layout/bottom_sheet_logout_and_backup.xml @@ -64,7 +64,6 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="8dp" - android:layout_marginLeft="8dp" android:textColor="?riotx_text_secondary" tools:text="@string/keys_backup_info_keys_all_backup_up" /> diff --git a/vector/src/main/res/layout/bottom_sheet_room_widget_permission.xml b/vector/src/main/res/layout/bottom_sheet_room_widget_permission.xml index e4df4b5c9a..56459e90d6 100644 --- a/vector/src/main/res/layout/bottom_sheet_room_widget_permission.xml +++ b/vector/src/main/res/layout/bottom_sheet_room_widget_permission.xml @@ -51,7 +51,6 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="8dp" - android:layout_marginLeft="8dp" android:layout_weight="1" android:orientation="vertical"> @@ -99,7 +98,6 @@ android:id="@+id/widgetPermissionDecline" style="@style/VectorButtonStyleDestructive" android:layout_marginEnd="@dimen/layout_vertical_margin" - android:layout_marginRight="@dimen/layout_vertical_margin" android:text="@string/decline" android:textAllCaps="true" /> @@ -107,7 +105,6 @@ android:id="@+id/widgetPermissionContinue" style="@style/VectorButtonStylePositive" android:layout_marginEnd="@dimen/layout_vertical_margin" - android:layout_marginRight="@dimen/layout_vertical_margin" android:minWidth="160dp" android:text="@string/_continue" android:textAllCaps="true" /> diff --git a/vector/src/main/res/layout/bottom_sheet_save_recovery_key.xml b/vector/src/main/res/layout/bottom_sheet_save_recovery_key.xml index b6fb49178d..4f528e6ef4 100644 --- a/vector/src/main/res/layout/bottom_sheet_save_recovery_key.xml +++ b/vector/src/main/res/layout/bottom_sheet_save_recovery_key.xml @@ -35,9 +35,9 @@ android:foreground="?attr/selectableItemBackground" android:minHeight="50dp" android:orientation="horizontal" - android:paddingLeft="@dimen/layout_horizontal_margin" + android:paddingStart="@dimen/layout_horizontal_margin" android:paddingTop="8dp" - android:paddingRight="@dimen/layout_horizontal_margin" + android:paddingEnd="@dimen/layout_horizontal_margin" android:paddingBottom="8dp"> @@ -66,9 +65,9 @@ android:foreground="?attr/selectableItemBackground" android:minHeight="50dp" android:orientation="horizontal" - android:paddingLeft="@dimen/layout_horizontal_margin" + android:paddingStart="@dimen/layout_horizontal_margin" android:paddingTop="8dp" - android:paddingRight="@dimen/layout_horizontal_margin" + android:paddingEnd="@dimen/layout_horizontal_margin" android:paddingBottom="8dp"> diff --git a/vector/src/main/res/layout/constraint_set_composer_layout_expanded.xml b/vector/src/main/res/layout/constraint_set_composer_layout_expanded.xml index bd59a14dd9..00f1830b1d 100644 --- a/vector/src/main/res/layout/constraint_set_composer_layout_expanded.xml +++ b/vector/src/main/res/layout/constraint_set_composer_layout_expanded.xml @@ -40,7 +40,6 @@ android:layout_width="40dp" android:layout_height="40dp" android:layout_marginStart="8dp" - android:layout_marginLeft="8dp" android:layout_marginTop="8dp" android:layout_marginBottom="8dp" app:layout_constraintBottom_toTopOf="@id/composer_related_message_action_image" @@ -105,11 +104,9 @@ android:layout_width="32dp" android:layout_height="32dp" android:layout_marginStart="8dp" - android:layout_marginLeft="8dp" android:layout_marginTop="8dp" android:layout_marginEnd="4dp" app:layout_goneMarginEnd="8dp" - android:layout_marginRight="8dp" android:layout_marginBottom="8dp" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toStartOf="@+id/composer_shield" diff --git a/vector/src/main/res/layout/dialog_base_edit_text.xml b/vector/src/main/res/layout/dialog_base_edit_text.xml index 98dc398042..1c4695a815 100644 --- a/vector/src/main/res/layout/dialog_base_edit_text.xml +++ b/vector/src/main/res/layout/dialog_base_edit_text.xml @@ -5,10 +5,8 @@ android:layout_height="match_parent" android:orientation="vertical" android:paddingStart="?dialogPreferredPadding" - android:paddingLeft="?dialogPreferredPadding" android:paddingTop="12dp" - android:paddingEnd="?dialogPreferredPadding" - android:paddingRight="?dialogPreferredPadding"> + android:paddingEnd="?dialogPreferredPadding"> + android:paddingEnd="?dialogPreferredPadding"> + app:layout_constraintTop_toTopOf="parent" + tools:text="@string/delete_event_dialog_content" /> + app:layout_constraintTop_toBottomOf="@+id/dialogReasonCheck" + tools:hint="@string/delete_event_dialog_reason_hint"> + android:paddingEnd="?dialogPreferredPadding"> + android:paddingEnd="?dialogPreferredPadding"> + android:layout_height="wrap_content" + android:hint="@string/power_level_custom_no_value"> + android:paddingEnd="?dialogPreferredPadding"> diff --git a/vector/src/main/res/layout/dialog_recovery_key_saved_info.xml b/vector/src/main/res/layout/dialog_recovery_key_saved_info.xml index 31a0255848..36c9a68077 100644 --- a/vector/src/main/res/layout/dialog_recovery_key_saved_info.xml +++ b/vector/src/main/res/layout/dialog_recovery_key_saved_info.xml @@ -5,10 +5,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:paddingStart="?dialogPreferredPadding" - android:paddingLeft="?dialogPreferredPadding" android:paddingTop="12dp" android:paddingEnd="?dialogPreferredPadding" - android:paddingRight="?dialogPreferredPadding" android:paddingBottom="12dp"> + android:paddingEnd="?dialogPreferredPadding"> diff --git a/vector/src/main/res/layout/dialog_ssl_fingerprint.xml b/vector/src/main/res/layout/dialog_ssl_fingerprint.xml index 3c1abc11a2..0c6fad871e 100644 --- a/vector/src/main/res/layout/dialog_ssl_fingerprint.xml +++ b/vector/src/main/res/layout/dialog_ssl_fingerprint.xml @@ -9,10 +9,8 @@ android:layout_height="wrap_content" android:orientation="vertical" android:paddingStart="?dialogPreferredPadding" - android:paddingLeft="?dialogPreferredPadding" android:paddingTop="12dp" - android:paddingEnd="?dialogPreferredPadding" - android:paddingRight="?dialogPreferredPadding"> + android:paddingEnd="?dialogPreferredPadding"> diff --git a/vector/src/main/res/layout/fragment_home_drawer.xml b/vector/src/main/res/layout/fragment_home_drawer.xml index 377c3ed17c..e09e26c575 100644 --- a/vector/src/main/res/layout/fragment_home_drawer.xml +++ b/vector/src/main/res/layout/fragment_home_drawer.xml @@ -32,7 +32,6 @@ android:layout_width="64dp" android:layout_height="64dp" android:layout_marginStart="@dimen/layout_horizontal_margin" - android:layout_marginLeft="@dimen/layout_horizontal_margin" android:layout_marginTop="24dp" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" diff --git a/vector/src/main/res/layout/fragment_keys_backup_restore_from_key.xml b/vector/src/main/res/layout/fragment_keys_backup_restore_from_key.xml index 3592ff074d..cdbc6d11de 100644 --- a/vector/src/main/res/layout/fragment_keys_backup_restore_from_key.xml +++ b/vector/src/main/res/layout/fragment_keys_backup_restore_from_key.xml @@ -42,7 +42,6 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginTop="16dp" app:errorEnabled="true" app:layout_constraintEnd_toStartOf="@+id/keys_backup_import" @@ -91,7 +90,6 @@ style="@style/VectorButtonStyle" android:layout_marginTop="@dimen/layout_vertical_margin_big" android:layout_marginEnd="@dimen/layout_horizontal_margin" - android:layout_marginRight="@dimen/layout_horizontal_margin" android:minWidth="200dp" android:text="@string/keys_backup_unlock_button" app:layout_constraintEnd_toEndOf="parent" diff --git a/vector/src/main/res/layout/fragment_keys_backup_restore_from_passphrase.xml b/vector/src/main/res/layout/fragment_keys_backup_restore_from_passphrase.xml index fe1e6efe78..4a963c590e 100644 --- a/vector/src/main/res/layout/fragment_keys_backup_restore_from_passphrase.xml +++ b/vector/src/main/res/layout/fragment_keys_backup_restore_from_passphrase.xml @@ -42,7 +42,6 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginTop="16dp" app:errorEnabled="true" app:layout_constraintEnd_toStartOf="@id/keys_backup_view_show_password" @@ -91,7 +90,6 @@ style="@style/VectorButtonStyle" android:layout_marginTop="@dimen/layout_vertical_margin_big" android:layout_marginEnd="@dimen/layout_horizontal_margin" - android:layout_marginRight="@dimen/layout_horizontal_margin" android:layout_marginBottom="@dimen/layout_vertical_margin_big" android:minWidth="200dp" android:text="@string/keys_backup_unlock_button" diff --git a/vector/src/main/res/layout/fragment_keys_backup_setup_step1.xml b/vector/src/main/res/layout/fragment_keys_backup_setup_step1.xml index d690aa777d..d9b6275e61 100644 --- a/vector/src/main/res/layout/fragment_keys_backup_setup_step1.xml +++ b/vector/src/main/res/layout/fragment_keys_backup_setup_step1.xml @@ -66,7 +66,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginStart="@dimen/layout_horizontal_margin" - android:layout_marginLeft="16dp" android:layout_marginTop="20dp" android:layout_marginEnd="@dimen/layout_horizontal_margin" android:text="@string/keys_backup_setup_step1_advanced" diff --git a/vector/src/main/res/layout/fragment_keys_backup_setup_step2.xml b/vector/src/main/res/layout/fragment_keys_backup_setup_step2.xml index 5c306eef48..fe8db20f4e 100644 --- a/vector/src/main/res/layout/fragment_keys_backup_setup_step2.xml +++ b/vector/src/main/res/layout/fragment_keys_backup_setup_step2.xml @@ -52,7 +52,6 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginTop="16dp" app:errorEnabled="true" app:layout_constraintEnd_toStartOf="@id/keys_backup_view_show_password" @@ -97,7 +96,6 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginTop="16dp" android:layout_weight="1" app:errorEnabled="true" @@ -120,7 +118,6 @@ style="@style/VectorButtonStyle" android:layout_marginTop="16dp" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:text="@string/keys_backup_setup_step2_button_title" android:textColor="@android:color/white" app:layout_constraintEnd_toEndOf="parent" @@ -132,10 +129,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginTop="20dp" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:text="@string/keys_backup_setup_step1_recovery_key_alternative" android:textAlignment="center" android:textColor="?riotx_text_primary" diff --git a/vector/src/main/res/layout/fragment_keys_backup_setup_step3.xml b/vector/src/main/res/layout/fragment_keys_backup_setup_step3.xml index bc92335ce0..7d3d821daf 100644 --- a/vector/src/main/res/layout/fragment_keys_backup_setup_step3.xml +++ b/vector/src/main/res/layout/fragment_keys_backup_setup_step3.xml @@ -26,9 +26,9 @@ android:id="@+id/keys_backup_setup_step3_success_title" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginLeft="@dimen/layout_horizontal_margin" + android:layout_marginStart="@dimen/layout_horizontal_margin" android:layout_marginTop="20dp" - android:layout_marginRight="@dimen/layout_horizontal_margin" + android:layout_marginEnd="@dimen/layout_horizontal_margin" android:text="@string/keys_backup_setup_step3_success_title" android:textAlignment="center" android:textColor="?riotx_text_primary" @@ -42,9 +42,9 @@ android:id="@+id/keys_backup_setup_step3_line1_text" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginLeft="@dimen/layout_horizontal_margin" + android:layout_marginStart="@dimen/layout_horizontal_margin" android:layout_marginTop="20dp" - android:layout_marginRight="@dimen/layout_horizontal_margin" + android:layout_marginEnd="@dimen/layout_horizontal_margin" android:text="@string/keys_backup_setup_step3_text_line1" android:textAlignment="center" android:textColor="?riotx_text_primary" @@ -54,9 +54,9 @@ android:id="@+id/keys_backup_setup_step3_line2_text" android:layout_width="match_parent" android:layout_height="wrap_content" - android:layout_marginLeft="@dimen/layout_horizontal_margin" + android:layout_marginStart="@dimen/layout_horizontal_margin" android:layout_marginTop="20dp" - android:layout_marginRight="@dimen/layout_horizontal_margin" + android:layout_marginEnd="@dimen/layout_horizontal_margin" android:textAlignment="center" android:textColor="?riotx_text_secondary" android:textSize="15sp" diff --git a/vector/src/main/res/layout/fragment_login.xml b/vector/src/main/res/layout/fragment_login.xml index 794048f3b3..608041ec03 100644 --- a/vector/src/main/res/layout/fragment_login.xml +++ b/vector/src/main/res/layout/fragment_login.xml @@ -82,7 +82,6 @@ android:inputType="textPassword" android:maxLines="1" android:paddingEnd="48dp" - android:paddingRight="48dp" tools:ignore="RtlSymmetry" /> diff --git a/vector/src/main/res/layout/fragment_login_reset_password.xml b/vector/src/main/res/layout/fragment_login_reset_password.xml index e2e908cf29..098bd047a9 100644 --- a/vector/src/main/res/layout/fragment_login_reset_password.xml +++ b/vector/src/main/res/layout/fragment_login_reset_password.xml @@ -72,7 +72,6 @@ android:inputType="textPassword" android:maxLines="1" android:paddingEnd="48dp" - android:paddingRight="48dp" tools:ignore="RtlSymmetry" /> diff --git a/vector/src/main/res/layout/fragment_public_rooms.xml b/vector/src/main/res/layout/fragment_public_rooms.xml index de448f3b8b..933bcf86aa 100644 --- a/vector/src/main/res/layout/fragment_public_rooms.xml +++ b/vector/src/main/res/layout/fragment_public_rooms.xml @@ -48,7 +48,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginTop="8dp" android:layout_marginBottom="8dp" android:minHeight="@dimen/layout_touch_size" diff --git a/vector/src/main/res/layout/fragment_room_list.xml b/vector/src/main/res/layout/fragment_room_list.xml index aa2eaacaaf..413d3957c1 100644 --- a/vector/src/main/res/layout/fragment_room_list.xml +++ b/vector/src/main/res/layout/fragment_room_list.xml @@ -28,7 +28,6 @@ android:layout_height="wrap_content" android:layout_gravity="bottom|end" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:layout_marginBottom="16dp" android:accessibilityTraversalBefore="@+id/roomListView" android:contentDescription="@string/a11y_create_direct_message" @@ -45,7 +44,6 @@ android:layout_height="wrap_content" android:layout_gravity="bottom|end" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:layout_marginBottom="16dp" android:accessibilityTraversalBefore="@+id/roomListView" android:contentDescription="@string/a11y_create_room" diff --git a/vector/src/main/res/layout/fragment_room_preview_no_preview.xml b/vector/src/main/res/layout/fragment_room_preview_no_preview.xml index dce0b27358..2f4db6f116 100644 --- a/vector/src/main/res/layout/fragment_room_preview_no_preview.xml +++ b/vector/src/main/res/layout/fragment_room_preview_no_preview.xml @@ -64,8 +64,8 @@ android:layout_height="wrap_content" android:gravity="center_horizontal" android:orientation="vertical" - android:paddingLeft="@dimen/layout_horizontal_margin" - android:paddingRight="@dimen/layout_horizontal_margin"> + android:paddingStart="@dimen/layout_horizontal_margin" + android:paddingEnd="@dimen/layout_horizontal_margin"> @@ -46,10 +44,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginTop="4dp" android:layout_marginEnd="8dp" - android:layout_marginRight="8dp" android:textColor="?riotx_text_secondary" tools:text="@string/settings_troubleshoot_diagnostic_running_status" /> diff --git a/vector/src/main/res/layout/fragment_ssss_access_from_passphrase.xml b/vector/src/main/res/layout/fragment_ssss_access_from_passphrase.xml index 005de93cf6..e5482f0ec7 100644 --- a/vector/src/main/res/layout/fragment_ssss_access_from_passphrase.xml +++ b/vector/src/main/res/layout/fragment_ssss_access_from_passphrase.xml @@ -15,11 +15,11 @@ android:layout_width="24dp" android:layout_height="24dp" android:layout_marginStart="16dp" + android:src="@drawable/ic_security_phrase_24dp" android:tint="?riotx_text_primary" app:layout_constraintBottom_toBottomOf="@+id/ssss_restore_with_passphrase" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toTopOf="@+id/ssss_restore_with_passphrase" - android:src="@drawable/ic_security_phrase_24dp" /> + app:layout_constraintTop_toTopOf="@+id/ssss_restore_with_passphrase" /> diff --git a/vector/src/main/res/layout/item_autocomplete_command.xml b/vector/src/main/res/layout/item_autocomplete_command.xml index ce2cd6c731..3e73da00ae 100644 --- a/vector/src/main/res/layout/item_autocomplete_command.xml +++ b/vector/src/main/res/layout/item_autocomplete_command.xml @@ -27,9 +27,7 @@ android:layout_height="wrap_content" android:layout_gravity="center_vertical" android:layout_marginStart="5dp" - android:layout_marginLeft="5dp" android:layout_toEndOf="@+id/commandName" - android:layout_toRightOf="@+id/commandName" android:maxLines="1" android:textColor="?riotx_text_secondary" android:textSize="12sp" @@ -42,7 +40,6 @@ android:layout_height="wrap_content" android:layout_below="@+id/commandName" android:layout_alignParentStart="true" - android:layout_alignParentLeft="true" android:layout_gravity="center_vertical" android:maxLines="2" android:textColor="?riotx_text_secondary" diff --git a/vector/src/main/res/layout/item_autocomplete_emoji.xml b/vector/src/main/res/layout/item_autocomplete_emoji.xml index c34ab0d452..fa628c0d24 100644 --- a/vector/src/main/res/layout/item_autocomplete_emoji.xml +++ b/vector/src/main/res/layout/item_autocomplete_emoji.xml @@ -23,7 +23,6 @@ android:layout_height="wrap_content" android:layout_gravity="center_vertical" android:layout_marginStart="8dp" - android:layout_marginLeft="8dp" android:orientation="vertical"> + tools:visibility="visible" /> @@ -48,10 +48,8 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginTop="4dp" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:layout_marginBottom="4dp" android:textColor="?riotx_text_secondary" android:visibility="gone" @@ -102,7 +100,6 @@ android:layout_height="wrap_content" android:layout_marginTop="4dp" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:layout_marginBottom="16dp" android:maxWidth="@dimen/button_max_width" android:visibility="gone" diff --git a/vector/src/main/res/layout/item_group.xml b/vector/src/main/res/layout/item_group.xml index 94d5041147..c42d1e26e9 100644 --- a/vector/src/main/res/layout/item_group.xml +++ b/vector/src/main/res/layout/item_group.xml @@ -16,7 +16,6 @@ android:layout_height="42dp" android:layout_gravity="center" android:layout_marginStart="@dimen/layout_horizontal_margin" - android:layout_marginLeft="@dimen/layout_horizontal_margin" android:duplicateParentState="true" app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator" app:layout_constraintStart_toStartOf="parent" @@ -45,7 +44,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="21dp" - android:layout_marginRight="21dp" android:src="@drawable/ic_arrow_right" android:tint="?riotx_text_primary" app:layout_constraintBottom_toTopOf="@+id/groupBottomSeparator" diff --git a/vector/src/main/res/layout/item_login_password_form.xml b/vector/src/main/res/layout/item_login_password_form.xml index 759da76a0d..19b0c5452b 100644 --- a/vector/src/main/res/layout/item_login_password_form.xml +++ b/vector/src/main/res/layout/item_login_password_form.xml @@ -30,7 +30,6 @@ android:inputType="textPassword" android:maxLines="1" android:paddingEnd="48dp" - android:paddingRight="48dp" tools:ignore="RtlSymmetry" /> diff --git a/vector/src/main/res/layout/item_notification_troubleshoot.xml b/vector/src/main/res/layout/item_notification_troubleshoot.xml index 7944e1969f..507b936d20 100644 --- a/vector/src/main/res/layout/item_notification_troubleshoot.xml +++ b/vector/src/main/res/layout/item_notification_troubleshoot.xml @@ -23,9 +23,7 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:paddingTop="4dp" android:paddingBottom="4dp" android:textColor="?riotx_text_primary" @@ -45,9 +43,7 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:paddingTop="4dp" android:paddingBottom="4dp" android:textColor="?riotx_text_secondary" @@ -66,9 +62,7 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:layout_marginBottom="16dp" android:background="?attr/colorAccent" android:padding="8dp" diff --git a/vector/src/main/res/layout/item_profile_action.xml b/vector/src/main/res/layout/item_profile_action.xml index b23ea5c084..6d3ba36d06 100644 --- a/vector/src/main/res/layout/item_profile_action.xml +++ b/vector/src/main/res/layout/item_profile_action.xml @@ -9,9 +9,9 @@ android:focusable="true" android:foreground="?attr/selectableItemBackground" android:minHeight="64dp" - android:paddingLeft="@dimen/layout_horizontal_margin" + android:paddingStart="@dimen/layout_horizontal_margin" android:paddingTop="8dp" - android:paddingRight="@dimen/layout_horizontal_margin" + android:paddingEnd="@dimen/layout_horizontal_margin" android:paddingBottom="8dp"> @@ -66,12 +66,12 @@ android:maxLines="1" android:textColor="?riotx_text_secondary" android:textSize="12sp" + app:layout_constrainedWidth="true" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toStartOf="@+id/matrixItemEditable" app:layout_constraintHorizontal_bias="0.0" app:layout_constraintStart_toEndOf="@id/matrixItemAvatar" app:layout_constraintTop_toBottomOf="@id/matrixItemTitle" - app:layout_constrainedWidth="true" app:layout_goneMarginStart="0dp" tools:text="@sample/matrix.json/data/mxid" /> diff --git a/vector/src/main/res/layout/item_profile_matrix_item_progress.xml b/vector/src/main/res/layout/item_profile_matrix_item_progress.xml index ccc6f66518..66cff4840e 100644 --- a/vector/src/main/res/layout/item_profile_matrix_item_progress.xml +++ b/vector/src/main/res/layout/item_profile_matrix_item_progress.xml @@ -9,9 +9,9 @@ android:focusable="true" android:foreground="?attr/selectableItemBackground" android:minHeight="64dp" - android:paddingLeft="@dimen/layout_horizontal_margin" + android:paddingStart="@dimen/layout_horizontal_margin" android:paddingTop="8dp" - android:paddingRight="@dimen/layout_horizontal_margin" + android:paddingEnd="@dimen/layout_horizontal_margin" android:paddingBottom="8dp"> @@ -20,8 +19,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginBottom="4dp" - tools:text=".m.rule.contains_user_name" - android:textStyle="bold" /> + android:textStyle="bold" + tools:text=".m.rule.contains_user_name" /> + tools:ignore="MissingConstraints" /> diff --git a/vector/src/main/res/layout/item_signout_action.xml b/vector/src/main/res/layout/item_signout_action.xml index c5acc09e56..16d10a3ff0 100644 --- a/vector/src/main/res/layout/item_signout_action.xml +++ b/vector/src/main/res/layout/item_signout_action.xml @@ -1,5 +1,5 @@ - + android:paddingEnd="@dimen/layout_horizontal_margin" + android:paddingBottom="8dp"> diff --git a/vector/src/main/res/layout/item_simple_reaction_info.xml b/vector/src/main/res/layout/item_simple_reaction_info.xml index 919e5b0a3e..73b0750cbd 100644 --- a/vector/src/main/res/layout/item_simple_reaction_info.xml +++ b/vector/src/main/res/layout/item_simple_reaction_info.xml @@ -15,7 +15,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="8dp" - android:layout_marginRight="8dp" android:gravity="center" android:lines="1" android:textColor="@color/black" diff --git a/vector/src/main/res/layout/item_timeline_event_base.xml b/vector/src/main/res/layout/item_timeline_event_base.xml index 853ece47e1..15016e0abe 100644 --- a/vector/src/main/res/layout/item_timeline_event_base.xml +++ b/vector/src/main/res/layout/item_timeline_event_base.xml @@ -29,10 +29,8 @@ android:layout_height="wrap_content" android:layout_alignParentTop="true" android:layout_marginStart="8dp" - android:layout_marginLeft="8dp" android:layout_marginTop="4dp" android:layout_marginEnd="4dp" - android:layout_marginRight="8dp" android:layout_toStartOf="@+id/messageTimeView" android:layout_toEndOf="@+id/messageStartGuideline" android:ellipsize="end" @@ -49,9 +47,7 @@ android:layout_alignBaseline="@+id/messageMemberNameView" android:layout_alignParentEnd="true" android:layout_marginStart="8dp" - android:layout_marginLeft="8dp" android:layout_marginEnd="8dp" - android:layout_marginRight="8dp" android:textColor="?riotx_text_secondary" android:textSize="12sp" tools:text="@tools:sample/date/hhmm" /> diff --git a/vector/src/main/res/layout/item_timeline_event_create.xml b/vector/src/main/res/layout/item_timeline_event_create.xml index d6fc5e4b5d..0fd63515d9 100644 --- a/vector/src/main/res/layout/item_timeline_event_create.xml +++ b/vector/src/main/res/layout/item_timeline_event_create.xml @@ -9,7 +9,6 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:layout_marginStart="16dp" - android:layout_marginLeft="16dp" android:layout_marginTop="16dp" android:layout_marginBottom="16dp" android:background="?attr/riotx_keys_backup_banner_accent_color" diff --git a/vector/src/main/res/layout/item_timeline_event_file_stub.xml b/vector/src/main/res/layout/item_timeline_event_file_stub.xml index a15de8bd34..a67d14168b 100644 --- a/vector/src/main/res/layout/item_timeline_event_file_stub.xml +++ b/vector/src/main/res/layout/item_timeline_event_file_stub.xml @@ -35,7 +35,6 @@ - @@ -46,7 +45,6 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="4dp" - android:layout_marginLeft="4dp" android:layout_marginEnd="32dp" android:autoLink="none" android:gravity="center_vertical" @@ -70,7 +68,6 @@ android:layout_height="46dp" android:layout_marginTop="8dp" android:layout_marginEnd="32dp" - android:layout_marginRight="32dp" android:visibility="gone" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" diff --git a/vector/src/main/res/layout/item_timeline_event_media_message_stub.xml b/vector/src/main/res/layout/item_timeline_event_media_message_stub.xml index 5df455b1c1..ad3b036a4d 100644 --- a/vector/src/main/res/layout/item_timeline_event_media_message_stub.xml +++ b/vector/src/main/res/layout/item_timeline_event_media_message_stub.xml @@ -10,7 +10,6 @@ android:layout_width="375dp" android:layout_height="0dp" android:layout_marginEnd="32dp" - android:layout_marginRight="32dp" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintHorizontal_bias="0" app:layout_constraintStart_toStartOf="parent" @@ -49,7 +48,6 @@ android:layout_height="46dp" android:layout_marginTop="8dp" android:layout_marginEnd="32dp" - android:layout_marginRight="32dp" android:layout_marginBottom="8dp" android:visibility="gone" app:layout_constraintEnd_toEndOf="parent" diff --git a/vector/src/main/res/layout/item_timeline_event_merged_header_stub.xml b/vector/src/main/res/layout/item_timeline_event_merged_header_stub.xml index 7f16b51abd..a0cfb6491f 100644 --- a/vector/src/main/res/layout/item_timeline_event_merged_header_stub.xml +++ b/vector/src/main/res/layout/item_timeline_event_merged_header_stub.xml @@ -14,21 +14,21 @@ layout="@layout/vector_message_merge_avatar_list" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:layout_marginTop="8dp" android:layout_alignParentStart="true" - android:layout_toLeftOf="@+id/itemMergedExpandTextView" - android:layout_marginEnd="16dp" /> + android:layout_marginTop="8dp" + android:layout_marginEnd="16dp" + android:layout_toStartOf="@+id/itemMergedExpandTextView" /> + android:background="?attr/riotx_header_panel_background" /> + android:layout_marginEnd="6dp" /> @@ -63,7 +62,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="8dp" - android:layout_marginRight="8dp" android:ellipsize="end" android:importantForAccessibility="no" android:text="@string/fab_menu_create_chat" /> diff --git a/vector/src/main/res/layout/reaction_button.xml b/vector/src/main/res/layout/reaction_button.xml index c23dd154e6..4f11bf1fcd 100644 --- a/vector/src/main/res/layout/reaction_button.xml +++ b/vector/src/main/res/layout/reaction_button.xml @@ -4,17 +4,17 @@ xmlns:tools="http://schemas.android.com/tools" android:id="@+id/reactionSelector" android:layout_width="wrap_content" - android:minWidth="44dp" android:layout_height="26dp" android:background="@drawable/rounded_rect_shape" - android:clipChildren="false"> + android:clipChildren="false" + android:minWidth="44dp"> - - - - + + + + diff --git a/vector/src/main/res/layout/vector_home_badge_unread_layout.xml b/vector/src/main/res/layout/vector_home_badge_unread_layout.xml index d4260bd472..051e7850df 100644 --- a/vector/src/main/res/layout/vector_home_badge_unread_layout.xml +++ b/vector/src/main/res/layout/vector_home_badge_unread_layout.xml @@ -11,13 +11,12 @@ android:layout_height="wrap_content" android:layout_gravity="top|center_horizontal" android:layout_marginStart="10dp" - android:layout_marginLeft="10dp" android:layout_marginTop="10dp" android:gravity="center" android:minWidth="8dp" android:minHeight="8dp" - android:paddingLeft="4dp" - android:paddingRight="4dp" + android:paddingStart="4dp" + android:paddingEnd="4dp" android:textColor="@android:color/white" android:textSize="10sp" tools:background="@drawable/bg_unread_highlight" diff --git a/vector/src/main/res/layout/vector_invite_view.xml b/vector/src/main/res/layout/vector_invite_view.xml index ed3f559ed2..159e394426 100644 --- a/vector/src/main/res/layout/vector_invite_view.xml +++ b/vector/src/main/res/layout/vector_invite_view.xml @@ -11,10 +11,8 @@ android:layout_width="96dp" android:layout_height="96dp" android:layout_marginStart="8dp" - android:layout_marginLeft="8dp" android:layout_marginTop="86dp" android:layout_marginEnd="8dp" - android:layout_marginRight="8dp" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toStartOf="parent" app:layout_constraintTop_toTopOf="parent" @@ -84,7 +82,7 @@ app:layout_constraintEnd_toStartOf="@+id/inviteAcceptView" app:layout_constraintHorizontal_chainStyle="packed" app:layout_constraintStart_toStartOf="parent" - app:layout_constraintTop_toBottomOf="@id/inviteLabelView"/> + app:layout_constraintTop_toBottomOf="@id/inviteLabelView" /> + android:paddingEnd="?android:attr/listPreferredItemPaddingRight"> diff --git a/vector/src/main/res/layout/view_jump_to_read_marker.xml b/vector/src/main/res/layout/view_jump_to_read_marker.xml index 48f7bd1d80..019480e6fe 100644 --- a/vector/src/main/res/layout/view_jump_to_read_marker.xml +++ b/vector/src/main/res/layout/view_jump_to_read_marker.xml @@ -29,13 +29,10 @@ android:layout_alignTop="@+id/jumpToReadMarkerLabelView" android:layout_alignBottom="@+id/jumpToReadMarkerLabelView" android:layout_alignParentEnd="true" - android:layout_alignParentRight="true" android:background="?attr/selectableItemBackground" android:contentDescription="@string/action_close" android:paddingStart="16dp" - android:paddingLeft="16dp" android:paddingEnd="16dp" - android:paddingRight="16dp" android:src="@drawable/ic_clear_white" /> diff --git a/vector/src/main/res/layout/view_keys_backup_banner.xml b/vector/src/main/res/layout/view_keys_backup_banner.xml index d9b66b9213..7e54823fae 100644 --- a/vector/src/main/res/layout/view_keys_backup_banner.xml +++ b/vector/src/main/res/layout/view_keys_backup_banner.xml @@ -13,7 +13,6 @@ android:layout_width="32dp" android:layout_height="32dp" android:layout_marginStart="19dp" - android:layout_marginLeft="19dp" android:src="@drawable/ic_secure_backup" android:tint="?riotx_text_primary" app:layout_constraintBottom_toBottomOf="parent" @@ -33,7 +32,6 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="27dp" - android:layout_marginLeft="27dp" android:text="@string/secure_backup_banner_setup_line1" android:textColor="?riotx_text_primary" android:textSize="18sp" @@ -47,7 +45,6 @@ android:layout_width="0dp" android:layout_height="wrap_content" android:layout_marginStart="27dp" - android:layout_marginLeft="27dp" android:text="@string/secure_backup_banner_setup_line2" android:textColor="?riotx_text_secondary" android:textSize="14sp" diff --git a/vector/src/main/res/layout/view_password_strength_bar.xml b/vector/src/main/res/layout/view_password_strength_bar.xml index b359cd140b..0b4361c7cb 100644 --- a/vector/src/main/res/layout/view_password_strength_bar.xml +++ b/vector/src/main/res/layout/view_password_strength_bar.xml @@ -11,7 +11,6 @@ android:layout_width="0dp" android:layout_height="4dp" android:layout_marginEnd="5dp" - android:layout_marginRight="5dp" android:layout_weight="1" tools:background="@color/password_strength_bar_weak" /> @@ -20,7 +19,6 @@ android:layout_width="0dp" android:layout_height="4dp" android:layout_marginEnd="5dp" - android:layout_marginRight="5dp" android:layout_weight="1" tools:background="@color/password_strength_bar_low" /> @@ -29,7 +27,6 @@ android:layout_width="0dp" android:layout_height="4dp" android:layout_marginEnd="5dp" - android:layout_marginRight="5dp" android:layout_weight="1" tools:background="@color/password_strength_bar_ok" /> diff --git a/vector/src/main/res/xml/motion_scene_fab_menu.xml b/vector/src/main/res/xml/motion_scene_fab_menu.xml index 646cfc34c5..0be402649a 100644 --- a/vector/src/main/res/xml/motion_scene_fab_menu.xml +++ b/vector/src/main/res/xml/motion_scene_fab_menu.xml @@ -73,7 +73,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="8dp" - android:layout_marginRight="8dp" android:text="@string/fab_menu_create_room" android:visibility="invisible" motion:layout_constraintBottom_toBottomOf="@+id/createRoomItemGroup" @@ -102,7 +101,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="8dp" - android:layout_marginRight="8dp" android:text="@string/fab_menu_create_chat" android:visibility="invisible" motion:layout_constraintBottom_toBottomOf="@+id/createRoomItemChat" @@ -115,7 +113,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:layout_marginBottom="16dp" android:src="@drawable/ic_fab_add" motion:layout_constraintBottom_toBottomOf="parent" @@ -153,7 +150,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="8dp" - android:layout_marginRight="8dp" android:text="@string/fab_menu_create_room" motion:layout_constraintBottom_toBottomOf="@+id/createRoomItemGroup" motion:layout_constraintEnd_toStartOf="@+id/createRoomItemGroup" @@ -180,7 +176,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="8dp" - android:layout_marginRight="8dp" android:text="@string/fab_menu_create_chat" motion:layout_constraintBottom_toBottomOf="@+id/createRoomItemChat" motion:layout_constraintEnd_toStartOf="@+id/createRoomItemChat" @@ -192,7 +187,6 @@ android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_marginEnd="16dp" - android:layout_marginRight="16dp" android:layout_marginBottom="16dp" android:rotation="135" android:src="@drawable/ic_fab_add"