From 672023e94b96f57cd84506bf73729026c87afa76 Mon Sep 17 00:00:00 2001 From: Benoit Marty Date: Mon, 2 May 2022 15:01:02 +0200 Subject: [PATCH] This is not necessary to map the EventId, it does not bring any new information. --- .../sdk/api/session/room/model/EventAnnotationsSummary.kt | 1 - .../sdk/api/session/room/model/ReferencesAggregatedSummary.kt | 1 - .../internal/database/mapper/EventAnnotationsSummaryMapper.kt | 2 -- .../sdk/internal/session/room/timeline/UIEchoManager.kt | 4 +--- 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/EventAnnotationsSummary.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/EventAnnotationsSummary.kt index 0238eb6c8d..a8140f3fc9 100644 --- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/EventAnnotationsSummary.kt +++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/EventAnnotationsSummary.kt @@ -16,7 +16,6 @@ package org.matrix.android.sdk.api.session.room.model data class EventAnnotationsSummary( - val eventId: String, val reactionsSummary: List = emptyList(), val editSummary: EditAggregatedSummary? = null, val pollResponseSummary: PollResponseAggregatedSummary? = null, diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/ReferencesAggregatedSummary.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/ReferencesAggregatedSummary.kt index 31ac09efb8..49ba2d5ab6 100644 --- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/ReferencesAggregatedSummary.kt +++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/session/room/model/ReferencesAggregatedSummary.kt @@ -22,7 +22,6 @@ import org.matrix.android.sdk.api.session.events.model.Content * of all events that are referencing the 'eventId' event via the RelationType.REFERENCE */ data class ReferencesAggregatedSummary( - val eventId: String, val content: Content?, val sourceEvents: List, val localEchos: List diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/mapper/EventAnnotationsSummaryMapper.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/mapper/EventAnnotationsSummaryMapper.kt index 4a26b4c4bf..b32d486128 100644 --- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/mapper/EventAnnotationsSummaryMapper.kt +++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/database/mapper/EventAnnotationsSummaryMapper.kt @@ -25,7 +25,6 @@ import org.matrix.android.sdk.internal.database.model.EventAnnotationsSummaryEnt internal object EventAnnotationsSummaryMapper { fun map(annotationsSummary: EventAnnotationsSummaryEntity): EventAnnotationsSummary { return EventAnnotationsSummary( - eventId = annotationsSummary.eventId, reactionsSummary = annotationsSummary.reactionsSummary.toList().map { ReactionAggregatedSummary( it.key, @@ -50,7 +49,6 @@ internal object EventAnnotationsSummaryMapper { }, referencesAggregatedSummary = annotationsSummary.referencesSummaryEntity?.let { ReferencesAggregatedSummary( - it.eventId, ContentMapper.map(it.content), it.sourceEvents.toList(), it.sourceLocalEcho.toList() diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/UIEchoManager.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/UIEchoManager.kt index bb92623249..f3218173d6 100644 --- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/UIEchoManager.kt +++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/room/timeline/UIEchoManager.kt @@ -98,9 +98,7 @@ internal class UIEchoManager(private val listener: Listener) { val relatedEventID = timelineEvent.eventId val contents = inMemoryReactions[relatedEventID] ?: return timelineEvent - var existingAnnotationSummary = timelineEvent.annotations ?: EventAnnotationsSummary( - relatedEventID - ) + var existingAnnotationSummary = timelineEvent.annotations ?: EventAnnotationsSummary() val updateReactions = existingAnnotationSummary.reactionsSummary.toMutableList() contents.forEach { uiEchoReaction ->