Merge branch 'release/1.3.2' into develop

CHANGES.md

@@ -1,3 +1,49 @@
+Changes in Element v1.3.2 (2021-10-08)
+======================================
+
+Features ✨
+----------
+ - Android Auto notification support ([#240](https://github.com/vector-im/element-android/issues/240))
+ - Add a fallback for user displayName when this one is null or empty ([#3732](https://github.com/vector-im/element-android/issues/3732))
+ - Add client base url config to customize permalinks ([#4027](https://github.com/vector-im/element-android/issues/4027))
+ - Check if DM exists before creating a new one ([#4157](https://github.com/vector-im/element-android/issues/4157))
+ - Handle 8 new slash commands: `/ignore`, `/unignore`, `/roomname`, `/myroomnick`, `/roomavatar`, `/myroomavatar`, `/lenny`, `/whois`. ([#4158](https://github.com/vector-im/element-android/issues/4158))
+ - Display identity server policies in the Discovery screen ([#4184](https://github.com/vector-im/element-android/issues/4184))
+
+Bugfixes 🐛
+----------
+ - Ensure initial sync progress dialog is hidden when the initial sync is over ([#983](https://github.com/vector-im/element-android/issues/983))
+ - Avoid resending notifications that are already shown ([#1673](https://github.com/vector-im/element-android/issues/1673))
+ - Room filter no results bad CTA in space mode when a space selected ([#3048](https://github.com/vector-im/element-android/issues/3048))
+ - Fixes notifications not dismissing when reading messages on other devices ([#3347](https://github.com/vector-im/element-android/issues/3347))
+ - Fixes the passphrase screen being incorrectly shown when pressing back on the key verification screen.
+  When the user doesn't have a passphrase set we don't show the passphrase screen. ([#3898](https://github.com/vector-im/element-android/issues/3898))
+ - App doesn't take you to a Space after choosing to Join it ([#3933](https://github.com/vector-im/element-android/issues/3933))
+ - Validate public space addresses and room aliases length ([#3934](https://github.com/vector-im/element-android/issues/3934))
+ - Save button for adding rooms to a space is hidden when scrolling through list of rooms ([#3935](https://github.com/vector-im/element-android/issues/3935))
+ - Align new room encryption default to Web ([#4045](https://github.com/vector-im/element-android/issues/4045))
+ - Fix Reply/Edit mode animation is broken when sending ([#4077](https://github.com/vector-im/element-android/issues/4077))
+ - Added changes that will make SearchView in search bar focused by default on opening reaction picker.
+
+  When tapping close icon of SearchView, the SearchView did not collapse therefore added the on close listener
+  which will collapse the SearchView on close. ([#4092](https://github.com/vector-im/element-android/issues/4092))
+ - Troubleshoot notification: Fix button not clickable ([#4109](https://github.com/vector-im/element-android/issues/4109))
+ - Harmonize wording in the message bottom sheet and move up the View Reactions item ([#4155](https://github.com/vector-im/element-android/issues/4155))
+ - Remove unused SendRelationWorker and related API call (3588) ([#4156](https://github.com/vector-im/element-android/issues/4156))
+ - SIP user to native user mapping is wrong ([#4176](https://github.com/vector-im/element-android/issues/4176))
+
+SDK API changes ⚠️
+------------------
+ - Create extension `String.isMxcUrl()` ([#4158](https://github.com/vector-im/element-android/issues/4158))
+
+Other changes
+-------------
+ - Use ktlint plugin. See [the documentation](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#ktlint) for more detail. ([#3957](https://github.com/vector-im/element-android/issues/3957))
+ - Minimize the use of exported="true" in android Manifest (link: https://github.com/matrix-org/matrix-dinsic/issues/618) ([#4018](https://github.com/vector-im/element-android/issues/4018))
+ - Fix redundancy in heading in the bug report issue form ([#4076](https://github.com/vector-im/element-android/issues/4076))
+ - Fix release label in the release issue template ([#4113](https://github.com/vector-im/element-android/issues/4113))
+
+
 Changes in Element v1.3.1 (2021-09-29)
 ======================================
 

changelog.d/1673.bugfix

@@ -1 +0,0 @@
-Avoid resending notifications that are already shown

changelog.d/240.feature

@@ -1 +0,0 @@
-Android Auto notification support

changelog.d/3048.bugfix

@@ -1 +0,0 @@
-Room filter no results bad CTA in space mode when a space selected

changelog.d/3347.bugfix

@@ -1 +0,0 @@
-Fixes notifications not dismissing when reading messages on other devices

changelog.d/3732.feature

@@ -1 +0,0 @@
-Add a fallback for user displayName when this one is null or empty

changelog.d/3898.bugfix

@@ -1,2 +0,0 @@
-Fixes the passphrase screen being incorrectly shown when pressing back on the key verification screen.
-When the user doesn't have a passphrase set we don't show the passphrase screen. 

changelog.d/3933.bugfix

@@ -1 +0,0 @@
-App doesn't take you to a Space after choosing to Join it

changelog.d/3934.bugfix

@@ -1 +0,0 @@
-Validate public space addresses and room aliases length

changelog.d/3935.bugfix

@@ -1 +0,0 @@
-Save button for adding rooms to a space is hidden when scrolling through list of rooms

changelog.d/3957.misc

@@ -1 +0,0 @@
-Use ktlint plugin. See [the documentation](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#ktlint) for more detail.

changelog.d/4018.misc

@@ -1 +0,0 @@
-Minimize the use of exported="true" in android Manifest (link: https://github.com/matrix-org/matrix-dinsic/issues/618)

changelog.d/4027.feature

@@ -1 +0,0 @@
-Add client base url config to customize permalinks

changelog.d/4045.bugfix

@@ -1 +0,0 @@
-Align new room encryption default to Web

changelog.d/4076.misc

@@ -1 +0,0 @@
-Fix redundancy in heading in the bug report issue form

changelog.d/4077.bugfix

@@ -1 +0,0 @@
-Fix Reply/Edit mode animation is broken when sending

changelog.d/4092.bugfix

@@ -1,4 +0,0 @@
-Added changes that will make SearchView in search bar focused by default on opening reaction picker.
-
-When tapping close icon of SearchView, the SearchView did not collapse therefore added the on close listener
-which will collapse the SearchView on close.

changelog.d/4109.bugfix

@@ -1 +0,0 @@
-Troubleshoot notification: Fix button not clickable

changelog.d/4113.misc

@@ -1 +0,0 @@
-Fix release label in the release issue template

changelog.d/4155.bugfix

@@ -1 +0,0 @@
-Harmonize wording in the message bottom sheet and move up the View Reactions item

changelog.d/4156.bugfix

@@ -1 +0,0 @@
-Remove unused SendRelationWorker and related API call (3588)

changelog.d/4157.feature

@@ -1 +0,0 @@
-Check if DM exists before creating a new one

changelog.d/4158.feature

@@ -1 +0,0 @@
-Handle 8 new slash commands: `/ignore`, `/unignore`, `/roomname`, `/myroomnick`, `/roomavatar`, `/myroomavatar`, `/lenny`, `/whois`.

changelog.d/4158.removal

@@ -1 +0,0 @@
-Create extension `String.isMxcUrl()`

changelog.d/4176.bugfix

@@ -1 +0,0 @@
-SIP user to native user mapping is wrong

changelog.d/4184.feature

@@ -1 +0,0 @@
-Display identity server policies in the Discovery screen

changelog.d/983.bugfix

@@ -1 +0,0 @@
-Ensure initial sync progress dialog is hidden when the initial sync is over

fastlane/metadata/android/en-US/changelogs/40103020.txt

@@ -0,0 +1,2 @@
+Main changes in this version: Add support for Android Auto. Lot of bug fixes!
+Full changelog: https://github.com/vector-im/element-android/releases/tag/v1.3.2

vector/src/androidTest/java/im/vector/app/ui/UiAllScreensSanityTest.kt

@@ -226,7 +226,7 @@ class UiAllScreensSanityTest {
         // Filter
         // TODO clickMenu(R.id.search)
         // Wait for emoji to load, it's async now
-        sleep(1_000)
+        sleep(2_000)
         clickListItem(R.id.emojiRecyclerView, 4)
 
         // Test Edit mode

vector/src/main/java/im/vector/app/features/settings/VectorSettingsGeneralFragment.kt

@@ -176,8 +176,7 @@ class VectorSettingsGeneralFragment @Inject constructor(
             mPasswordPreference.isVisible = false
         }
 
-        val discoveryPreference = findPreference<VectorPreference>(VectorPreferences.SETTINGS_DISCOVERY_PREFERENCE_KEY)!!
+        val openDiscoveryScreenPreferenceClickListener = Preference.OnPreferenceClickListener {
-        discoveryPreference.onPreferenceClickListener = Preference.OnPreferenceClickListener {
             (requireActivity() as VectorSettingsActivity).navigateTo(
                     DiscoverySettingsFragment::class.java,
                     SettingsActivityPayload.DiscoverySettings().toMvRxBundle()
@@ -185,6 +184,11 @@ class VectorSettingsGeneralFragment @Inject constructor(
             true
         }
 
+        val discoveryPreference = findPreference<VectorPreference>(VectorPreferences.SETTINGS_DISCOVERY_PREFERENCE_KEY)!!
+        discoveryPreference.onPreferenceClickListener = openDiscoveryScreenPreferenceClickListener
+
+        mIdentityServerPreference.onPreferenceClickListener = openDiscoveryScreenPreferenceClickListener
+
         // Advanced settings
 
         // user account

vector/src/main/res/xml/vector_settings_general.xml

@@ -87,7 +87,6 @@
         <im.vector.app.core.preference.VectorPreference
             android:key="SETTINGS_IDENTITY_SERVER_PREFERENCE_KEY"
             android:title="@string/settings_identity_server"
-            app:fragment="im.vector.app.features.discovery.DiscoverySettingsFragment"
             tools:summary="https://identity.server.url" />
 
         <im.vector.app.core.preference.VectorPreference