From 037d1fcf521c63ab8b9cf2fb9040635d05c223ce Mon Sep 17 00:00:00 2001 From: Adam Brown Date: Wed, 3 Nov 2021 15:07:44 +0000 Subject: [PATCH] adding catch around the push event dispatching to match previous behaviour --- .../session/notification/DefaultPushRuleService.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/notification/DefaultPushRuleService.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/notification/DefaultPushRuleService.kt index aaaeb4874e..3e821b8956 100644 --- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/notification/DefaultPushRuleService.kt +++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/notification/DefaultPushRuleService.kt @@ -41,6 +41,7 @@ import org.matrix.android.sdk.internal.session.pushers.UpdatePushRuleActionsTask import org.matrix.android.sdk.internal.session.pushers.UpdatePushRuleEnableStatusTask import org.matrix.android.sdk.internal.task.TaskExecutor import org.matrix.android.sdk.internal.task.configureWith +import timber.log.Timber import javax.inject.Inject @SessionScope @@ -160,7 +161,11 @@ internal class DefaultPushRuleService @Inject constructor( fun dispatchEvents(pushEvents: PushEvents) { synchronized(listeners) { listeners.forEach { - it.onEvents(pushEvents) + try { + it.onEvents(pushEvents) + } catch (e: Throwable) { + Timber.e(e, "Error while dispatching push events") + } } } }