Merge pull request #4592 from vector-im/feature/aris/epoxy_controller_init_improvement

Feature/aris/epoxy controller init improvement

changelog.d/4591.misc

@@ -0,0 +1 @@
+Remove requestModelBuild() from epoxy Controllers init{} block

vector/src/main/java/im/vector/app/features/contactsbook/ContactsBookController.kt

@@ -41,10 +41,6 @@ class ContactsBookController @Inject constructor(
 
     var callback: Callback? = null
 
-    init {
-        requestModelBuild()
-    }
-
     fun setData(state: ContactsBookViewState) {
         this.state = state
         requestModelBuild()

vector/src/main/java/im/vector/app/features/devtools/RoomDevToolRootController.kt

@@ -26,10 +26,6 @@ class RoomDevToolRootController @Inject constructor(
         private val stringProvider: StringProvider
 ) : EpoxyController() {
 
-    init {
-        requestModelBuild()
-    }
-
     var interactionListener: DevToolsInteractionListener? = null
 
     override fun buildModels() {

vector/src/main/java/im/vector/app/features/home/room/breadcrumbs/BreadcrumbsController.kt

@@ -30,12 +30,6 @@ class BreadcrumbsController @Inject constructor(
 
     private var viewState: BreadcrumbsViewState? = null
 
-    init {
-        // We are requesting a model build directly as the first build of epoxy is on the main thread.
-        // It avoids to build the whole list of breadcrumbs on the main thread.
-        requestModelBuild()
-    }
-
     fun update(viewState: BreadcrumbsViewState) {
         this.viewState = viewState
         requestModelBuild()

vector/src/main/java/im/vector/app/features/settings/devices/DevicesController.kt

@@ -46,10 +46,6 @@ class DevicesController @Inject constructor(private val errorFormatter: ErrorFor
     var callback: Callback? = null
     private var viewState: DevicesViewState? = null
 
-    init {
-        requestModelBuild()
-    }
-
     fun update(viewState: DevicesViewState) {
         this.viewState = viewState
         requestModelBuild()

vector/src/main/java/im/vector/app/features/settings/ignored/IgnoredUsersController.kt

@@ -31,10 +31,6 @@ class IgnoredUsersController @Inject constructor(private val stringProvider: Str
     var callback: Callback? = null
     private var viewState: IgnoredUsersViewState? = null
 
-    init {
-        requestModelBuild()
-    }
-
     fun update(viewState: IgnoredUsersViewState) {
         this.viewState = viewState
         requestModelBuild()

vector/src/main/java/im/vector/app/features/signout/soft/SoftLogoutController.kt

@@ -45,12 +45,6 @@ class SoftLogoutController @Inject constructor(
 
     private var viewState: SoftLogoutViewState? = null
 
-    init {
-        // We are requesting a model build directly as the first build of epoxy is on the main thread.
-        // It avoids to build the whole list of breadcrumbs on the main thread.
-        requestModelBuild()
-    }
-
     fun update(viewState: SoftLogoutViewState) {
         this.viewState = viewState
         requestModelBuild()

vector/src/main/java/im/vector/app/features/spaces/SpaceSummaryController.kt

@@ -47,10 +47,6 @@ class SpaceSummaryController @Inject constructor(
 
     private val subSpaceComparator: Comparator<SpaceChildInfo> = compareBy<SpaceChildInfo> { it.order }.thenBy { it.childRoomId }
 
-    init {
-        requestModelBuild()
-    }
-
     fun update(viewState: SpaceListViewState) {
         this.viewState = viewState
         requestModelBuild()