mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2024-11-28 18:08:51 +03:00
f5602d9c46
Merge in DNS/adguard-home from hup-reload to master Squashed commit of the following: commit 5cd4ab85bdc7544a4eded2a61f5a5571175daa44 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Oct 7 19:58:17 2022 +0300 next: imp signal hdlr commit 8fd18e749fec46982d26fc408e661bd802586c37 Merge: a8780455f1dd3334
Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Oct 7 19:46:48 2022 +0300 Merge branch 'master' into hup-reload commit a87804550e15d7fe3d9ded2e5a736c395f96febd Merge: 349dbe54960a7a75
Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Oct 7 15:49:23 2022 +0300 Merge branch 'master' into hup-reload commit 349dbe54fe27eeaf56776c73c3cc5649018d4c60 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Oct 7 15:43:52 2022 +0300 next: imp docs, names commit 7287a86d283489127453009267911003cea5227e Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Oct 7 13:39:44 2022 +0300 WIP all: impl dynamic reconfiguration
110 lines
2.9 KiB
Go
110 lines
2.9 KiB
Go
package websvc
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"net/netip"
|
|
"time"
|
|
|
|
"github.com/AdguardTeam/AdGuardHome/internal/next/agh"
|
|
"github.com/AdguardTeam/golibs/log"
|
|
)
|
|
|
|
// HTTP Settings Handlers
|
|
|
|
// ReqPatchSettingsHTTP describes the request to the PATCH /api/v1/settings/http
|
|
// HTTP API.
|
|
type ReqPatchSettingsHTTP struct {
|
|
// TODO(a.garipov): Add more as we go.
|
|
//
|
|
// TODO(a.garipov): Add wait time.
|
|
|
|
Addresses []netip.AddrPort `json:"addresses"`
|
|
SecureAddresses []netip.AddrPort `json:"secure_addresses"`
|
|
Timeout JSONDuration `json:"timeout"`
|
|
}
|
|
|
|
// HTTPAPIHTTPSettings are the HTTP settings as used by the HTTP API. See the
|
|
// HttpSettings object in the OpenAPI specification.
|
|
type HTTPAPIHTTPSettings struct {
|
|
// TODO(a.garipov): Add more as we go.
|
|
|
|
Addresses []netip.AddrPort `json:"addresses"`
|
|
SecureAddresses []netip.AddrPort `json:"secure_addresses"`
|
|
Timeout JSONDuration `json:"timeout"`
|
|
ForceHTTPS bool `json:"force_https"`
|
|
}
|
|
|
|
// handlePatchSettingsHTTP is the handler for the PATCH /api/v1/settings/http
|
|
// HTTP API.
|
|
func (svc *Service) handlePatchSettingsHTTP(w http.ResponseWriter, r *http.Request) {
|
|
req := &ReqPatchSettingsHTTP{}
|
|
|
|
// TODO(a.garipov): Validate nulls and proper JSON patch.
|
|
|
|
err := json.NewDecoder(r.Body).Decode(&req)
|
|
if err != nil {
|
|
writeJSONErrorResponse(w, r, fmt.Errorf("decoding: %w", err))
|
|
|
|
return
|
|
}
|
|
|
|
newConf := &Config{
|
|
ConfigManager: svc.confMgr,
|
|
TLS: svc.tls,
|
|
Addresses: req.Addresses,
|
|
SecureAddresses: req.SecureAddresses,
|
|
Timeout: time.Duration(req.Timeout),
|
|
ForceHTTPS: svc.forceHTTPS,
|
|
}
|
|
|
|
writeJSONOKResponse(w, r, &HTTPAPIHTTPSettings{
|
|
Addresses: newConf.Addresses,
|
|
SecureAddresses: newConf.SecureAddresses,
|
|
Timeout: JSONDuration(newConf.Timeout),
|
|
ForceHTTPS: newConf.ForceHTTPS,
|
|
})
|
|
|
|
cancelUpd := func() {}
|
|
updCtx := context.Background()
|
|
|
|
ctx := r.Context()
|
|
if deadline, ok := ctx.Deadline(); ok {
|
|
updCtx, cancelUpd = context.WithDeadline(updCtx, deadline)
|
|
}
|
|
|
|
// Launch the new HTTP service in a separate goroutine to let this handler
|
|
// finish and thus, this server to shutdown.
|
|
go func() {
|
|
defer cancelUpd()
|
|
|
|
updErr := svc.confMgr.UpdateWeb(updCtx, newConf)
|
|
if updErr != nil {
|
|
writeJSONErrorResponse(w, r, fmt.Errorf("updating: %w", updErr))
|
|
|
|
return
|
|
}
|
|
|
|
// TODO(a.garipov): Consider better ways to do this.
|
|
const maxUpdDur = 10 * time.Second
|
|
updStart := time.Now()
|
|
var newSvc agh.ServiceWithConfig[*Config]
|
|
for newSvc = svc.confMgr.Web(); newSvc == svc; {
|
|
if time.Since(updStart) >= maxUpdDur {
|
|
log.Error("websvc: failed to update svc after %s", maxUpdDur)
|
|
|
|
return
|
|
}
|
|
|
|
log.Debug("websvc: waiting for new websvc to be configured")
|
|
time.Sleep(1 * time.Second)
|
|
}
|
|
|
|
updErr = newSvc.Start()
|
|
if updErr != nil {
|
|
log.Error("websvc: new svc failed to start with error: %s", updErr)
|
|
}
|
|
}()
|
|
}
|