mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2024-12-18 21:11:50 +03:00
e77de2e67d
Closes #7314. Squashed commit of the following: commit f8b6ffeec2f0f96c947cf896c75d05efaca77caf Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Tue Oct 29 14:14:41 2024 +0300 all: fix chlog commit9417b7dc51
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Mon Oct 28 19:41:30 2024 +0300 aghos: imp doc commitb91f0e72a7
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Mon Oct 28 19:26:15 2024 +0300 all: rm bin commit9008ee93b1
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Mon Oct 28 18:23:54 2024 +0300 all: revert permcheck commitbcc85d50f5
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Mon Oct 28 17:48:55 2024 +0300 all: use aghos more commit993e351712
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Mon Oct 28 16:24:56 2024 +0300 all: fix more bugs commita22b0d265e
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Oct 25 18:30:52 2024 +0300 all: fix bugs commita2309f812a
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Oct 25 17:05:08 2024 +0300 all: fix chlog, imp api commit42c3f8e91c
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Oct 25 16:04:47 2024 +0300 scripts: fix docs commit9e781ff18d
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Oct 25 16:03:19 2024 +0300 scripts: imp docs commit1dbc784982
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Oct 25 15:55:16 2024 +0300 all: use new functions, add tests commitdcbabaf4e3
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Fri Oct 25 13:23:50 2024 +0300 aghos: add stat commit72d7c0f881
Author: Eugene Burkov <E.Burkov@AdGuard.COM> Date: Thu Oct 24 17:10:30 2024 +0300 aghos: add windows functions
93 lines
2.6 KiB
Go
93 lines
2.6 KiB
Go
package permcheck
|
|
|
|
import (
|
|
"io/fs"
|
|
"os"
|
|
"path/filepath"
|
|
|
|
"github.com/AdguardTeam/AdGuardHome/internal/aghos"
|
|
"github.com/AdguardTeam/golibs/errors"
|
|
"github.com/AdguardTeam/golibs/log"
|
|
)
|
|
|
|
// NeedsMigration returns true if AdGuard Home files need permission migration.
|
|
//
|
|
// TODO(a.garipov): Consider ways to detect this better.
|
|
func NeedsMigration(confFilePath string) (ok bool) {
|
|
s, err := aghos.Stat(confFilePath)
|
|
if err != nil {
|
|
if errors.Is(err, os.ErrNotExist) {
|
|
// Likely a first run. Don't check.
|
|
return false
|
|
}
|
|
|
|
log.Error("permcheck: checking if files need migration: %s", err)
|
|
|
|
// Unexpected error. Try to migrate just in case.
|
|
return true
|
|
}
|
|
|
|
return s.Mode().Perm() != aghos.DefaultPermFile
|
|
}
|
|
|
|
// Migrate attempts to change the permissions of AdGuard Home's files. It logs
|
|
// the results at an appropriate level.
|
|
func Migrate(workDir, dataDir, statsDir, querylogDir, confFilePath string) {
|
|
chmodDir(workDir)
|
|
|
|
chmodFile(confFilePath)
|
|
|
|
// TODO(a.garipov): Put all paths in one place and remove this duplication.
|
|
chmodDir(dataDir)
|
|
chmodDir(filepath.Join(dataDir, "filters"))
|
|
chmodFile(filepath.Join(dataDir, "sessions.db"))
|
|
chmodFile(filepath.Join(dataDir, "leases.json"))
|
|
|
|
if dataDir != querylogDir {
|
|
chmodDir(querylogDir)
|
|
}
|
|
chmodFile(filepath.Join(querylogDir, "querylog.json"))
|
|
chmodFile(filepath.Join(querylogDir, "querylog.json.1"))
|
|
|
|
if dataDir != statsDir {
|
|
chmodDir(statsDir)
|
|
}
|
|
chmodFile(filepath.Join(statsDir, "stats.db"))
|
|
}
|
|
|
|
// chmodDir changes the permissions of a single directory. The results are
|
|
// logged at the appropriate level.
|
|
func chmodDir(dirPath string) {
|
|
chmodPath(dirPath, typeDir, aghos.DefaultPermDir)
|
|
}
|
|
|
|
// chmodFile changes the permissions of a single file. The results are logged
|
|
// at the appropriate level.
|
|
func chmodFile(filePath string) {
|
|
chmodPath(filePath, typeFile, aghos.DefaultPermFile)
|
|
}
|
|
|
|
// chmodPath changes the permissions of a single filesystem entity. The results
|
|
// are logged at the appropriate level.
|
|
func chmodPath(entPath, fileType string, fm fs.FileMode) {
|
|
err := aghos.Chmod(entPath, fm)
|
|
if err == nil {
|
|
log.Info("permcheck: changed permissions for %s %q", fileType, entPath)
|
|
|
|
return
|
|
} else if errors.Is(err, os.ErrNotExist) {
|
|
log.Debug("permcheck: changing permissions for %s %q: %s", fileType, entPath, err)
|
|
|
|
return
|
|
}
|
|
|
|
log.Error(
|
|
"permcheck: SECURITY WARNING: cannot change permissions for %s %q to %#o: %s; "+
|
|
"this can leave your system vulnerable, see "+
|
|
"https://adguard-dns.io/kb/adguard-home/running-securely/#os-service-concerns",
|
|
fileType,
|
|
entPath,
|
|
fm,
|
|
err,
|
|
)
|
|
}
|