From d42718465da849a76569332fc2fe97d2fc47e5cf Mon Sep 17 00:00:00 2001
From: Eugene Bujak <hmage@hmage.net>
Date: Fri, 1 Feb 2019 14:10:39 +0300
Subject: [PATCH] /tls/configure -- certificates/keys are now transferred
 encoded with base64

---
 control.go | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/control.go b/control.go
index 4598c859..ca699f66 100644
--- a/control.go
+++ b/control.go
@@ -5,6 +5,7 @@ import (
 	"context"
 	"crypto/tls"
 	"crypto/x509"
+	"encoding/base64"
 	"encoding/json"
 	"encoding/pem"
 	"fmt"
@@ -1048,7 +1049,21 @@ func handleTLSConfigure(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	_, err = tls.X509KeyPair([]byte(data.CertificateChain), []byte(data.PrivateKey))
+	certPEM, err := base64.StdEncoding.DecodeString(data.CertificateChain)
+	if err != nil {
+		httpError(w, http.StatusBadRequest, "Failed to base64-decode certificate chain: %s", err)
+		return
+	}
+
+	keyPEM, err := base64.StdEncoding.DecodeString(data.PrivateKey)
+	if err != nil {
+		httpError(w, http.StatusBadRequest, "Failed to base64-decode private key: %s", err)
+		return
+	}
+
+	log.Printf("got certificate: %s", certPEM)
+
+	_, err = tls.X509KeyPair(certPEM, keyPEM)
 	if err != nil {
 		httpError(w, http.StatusBadRequest, "Invalid certificate or key: %s", err)
 		return
@@ -1058,7 +1073,7 @@ func handleTLSConfigure(w http.ResponseWriter, r *http.Request) {
 	var certs []*pem.Block    // PEM-encoded certificates
 	var skippedBytes []string // skipped bytes
 
-	pemblock := []byte(data.CertificateChain)
+	pemblock := []byte(certPEM)
 	for {
 		var decoded *pem.Block
 		decoded, pemblock = pem.Decode(pemblock)
@@ -1109,6 +1124,7 @@ func handleTLSConfigure(w http.ResponseWriter, r *http.Request) {
 	mainCert := parsedCerts[0]
 	_, err = mainCert.Verify(opts)
 	if err != nil {
+		// TODO: let self-signed certs through
 		httpError(w, http.StatusBadRequest, "Your certificate does not verify: %s", err)
 		return
 	}