From 5da7751463ca621ac76d59fb47f8b037d48cd208 Mon Sep 17 00:00:00 2001
From: Ainar Garipov <a.garipov@adguard.com>
Date: Thu, 13 Apr 2023 20:51:57 +0300
Subject: [PATCH] Pull request 1829: 5725-querylog-orig-ans
Closes #5725.
Squashed commit of the following:
commit a9e5fc47fc0a752f427e006ab1c59e260239ee5a
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date: Thu Apr 13 20:25:12 2023 +0300
querylog: fix orig ans assignment
---
CHANGELOG.md | 3 +++
internal/querylog/entry.go | 6 +++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index a3b495f3..bb353fb3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -25,10 +25,13 @@ NOTE: Add new changes BELOW THIS COMMENT.
### Fixed
+- Incorrect recording of blocked results as “Blocked by CNAME or IP” in the
+ query log ([#5725]).
- All Safe Search services being unchecked by default.
- Panic when a DNSCrypt stamp is invalid ([#5721]).
[#5721]: https://github.com/AdguardTeam/AdGuardHome/issues/5721
+[#5725]: https://github.com/AdguardTeam/AdGuardHome/issues/5725
<!--
NOTE: Add new changes ABOVE THIS COMMENT.
diff --git a/internal/querylog/entry.go b/internal/querylog/entry.go
index 0433744c..eae99385 100644
--- a/internal/querylog/entry.go
+++ b/internal/querylog/entry.go
@@ -58,11 +58,11 @@ func (e *logEntry) addResponse(resp *dns.Msg, isOrig bool) {
var err error
if isOrig {
- e.Answer, err = resp.Pack()
- err = errors.Annotate(err, "packing answer: %w")
- } else {
e.OrigAnswer, err = resp.Pack()
err = errors.Annotate(err, "packing orig answer: %w")
+ } else {
+ e.Answer, err = resp.Pack()
+ err = errors.Annotate(err, "packing answer: %w")
}
if err != nil {
log.Error("querylog: %s", err)