diff --git a/internal/client/persistent_internal_test.go b/internal/client/persistent_internal_test.go index 395ffa72..c62b76da 100644 --- a/internal/client/persistent_internal_test.go +++ b/internal/client/persistent_internal_test.go @@ -1,10 +1,8 @@ package client import ( - "net/netip" "testing" - "github.com/AdguardTeam/golibs/testutil" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" ) @@ -124,69 +122,3 @@ func TestPersistent_EqualIDs(t *testing.T) { }) } } - -func TestPersistent_Validate(t *testing.T) { - const ( - allowedTag = "allowed_tag" - notAllowedTag = "not_allowed_tag" - ) - - allowedTags := []string{allowedTag} - - testCases := []struct { - name string - cli *Persistent - wantErrMsg string - }{{ - name: "success", - cli: &Persistent{ - Name: "basic", - IPs: []netip.Addr{ - netip.MustParseAddr("1.2.3.4"), - }, - UID: MustNewUID(), - }, - wantErrMsg: "", - }, { - name: "empty_name", - cli: &Persistent{ - Name: "", - }, - wantErrMsg: "empty name", - }, { - name: "no_id", - cli: &Persistent{ - Name: "no_id", - }, - wantErrMsg: "id required", - }, { - name: "no_uid", - cli: &Persistent{ - Name: "no_uid", - IPs: []netip.Addr{ - netip.MustParseAddr("1.2.3.4"), - }, - }, - wantErrMsg: "uid required", - }, { - name: "not_allowed_tag", - cli: &Persistent{ - Name: "basic", - IPs: []netip.Addr{ - netip.MustParseAddr("1.2.3.4"), - }, - UID: MustNewUID(), - Tags: []string{ - notAllowedTag, - }, - }, - wantErrMsg: `invalid tag: "` + notAllowedTag + `"`, - }} - - for _, tc := range testCases { - t.Run(tc.name, func(t *testing.T) { - err := tc.cli.validate(allowedTags) - testutil.AssertErrorMsg(t, tc.wantErrMsg, err) - }) - } -} diff --git a/internal/client/storage_test.go b/internal/client/storage_test.go index 58311f4c..60d766d0 100644 --- a/internal/client/storage_test.go +++ b/internal/client/storage_test.go @@ -643,6 +643,28 @@ func TestStorage_Add(t *testing.T) { UID: client.MustNewUID(), }, wantErrMsg: "", + }, { + name: "", + cli: &client.Persistent{ + Name: "", + IPs: []netip.Addr{netip.MustParseAddr("6.6.6.6")}, + UID: client.MustNewUID(), + }, + wantErrMsg: "adding client: empty name", + }, { + name: "no_id", + cli: &client.Persistent{ + Name: "no_id", + UID: client.MustNewUID(), + }, + wantErrMsg: "adding client: id required", + }, { + name: "no_uid", + cli: &client.Persistent{ + Name: "no_uid", + IPs: []netip.Addr{netip.MustParseAddr("7.7.7.7")}, + }, + wantErrMsg: "adding client: uid required", }} for _, tc := range testCases {